-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stats traffic remove today card #20242
Conversation
Remove Today Stats from Insights when TrafficTab is enabled
Add Today Stats only when Traffic Tab is not enabled
|
App Name | ![]() |
|
Flavor | Jalapeno | |
Build Type | Debug | |
Version | pr20242-cc8d3ca | |
Commit | cc8d3ca | |
Direct Download | jetpack-prototype-build-pr20242-cc8d3ca.apk |
|
App Name | ![]() |
|
Flavor | Jalapeno | |
Build Type | Debug | |
Version | pr20242-cc8d3ca | |
Commit | cc8d3ca | |
Direct Download | wordpress-prototype-build-pr20242-cc8d3ca.apk |
7da16f8
to
88734d0
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## trunk #20242 +/- ##
=======================================
Coverage 40.31% 40.32%
=======================================
Files 1469 1469
Lines 67691 67698 +7
Branches 11209 11212 +3
=======================================
+ Hits 27293 27302 +9
+ Misses 37904 37901 -3
- Partials 2494 2495 +1 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 👍🏻 I've added a minor comment.
Today card is not being removed without restarting the app. But I think it's fine because we fetch new configs when only starting the app.
...ress/android/ui/stats/refresh/lists/sections/insights/management/InsightsManagementMapper.kt
Outdated
Show resolved
Hide resolved
Remove IS_JETPACK_APP check since Stats only on Jetpack app now
fix detekt warning about imports
Fixes #20241
To Test:
Test 1:
stats_traffic_tab
feature flag (Me -> Debug settings - Remote Features)Verify
only Traffic tab, and Insights tabs are shownSwitch
to Insights tab if not on it alreadyTap
on Insights settings (⚙️)Verify
there's no Today Stats option under GeneralVerify
that Today card is not shownTest 2:
stats_traffic_tab
feature flagSwitch
to Insights tab if not on it alreadyTap
on Insights settings (⚙️)Verify
there's Today Stats option under GeneralEnable
Today Stats by tapping on it, and press SaveVerify
that Today card is shownRegression Notes
Potential unintended areas of impact
What I did to test those areas of impact (or what existing automated tests I relied on)
What automated tests I added (or what prevented me from doing so)
PR Submission Checklist:
RELEASE-NOTES.txt
if necessary.