-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stories Additional Code Removals #20341
Conversation
Generated by 🚫 Danger |
|
App Name | ![]() |
|
Flavor | Jalapeno | |
Build Type | Debug | |
Version | pr20341-a6801a9 | |
Commit | a6801a9 | |
Direct Download | wordpress-prototype-build-pr20341-a6801a9.apk |
|
App Name | ![]() |
|
Flavor | Jalapeno | |
Build Type | Debug | |
Version | pr20341-a6801a9 | |
Commit | a6801a9 | |
Direct Download | jetpack-prototype-build-pr20341-a6801a9.apk |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## issue/stories-removal #20341 +/- ##
======================================================
Coverage 40.48% 40.48%
======================================================
Files 1458 1458
Lines 66996 66988 -8
Branches 11105 11104 -1
======================================================
- Hits 27124 27122 -2
+ Misses 37391 37386 -5
+ Partials 2481 2480 -1 ☔ View full report in Codecov by Sentry. |
drawableLeft = Drawable(R.drawable.ic_pages_white_24dp), | ||
drawableRight = Drawable(R.drawable.ic_pages_white_24dp), | ||
drawableTop = Drawable(R.drawable.ic_pages_white_24dp), | ||
drawableBottom = Drawable(R.drawable.ic_pages_white_24dp), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think any random icon would fit the purposes of the preview
@@ -425,7 +425,7 @@ fun MySiteListItemPreviewWithSecondaryImage() { | |||
MenuItemState.MenuListItem( | |||
primaryIcon = R.drawable.ic_posts_white_24dp, | |||
primaryText = UiString.UiStringText("Plans"), | |||
secondaryIcon = R.drawable.ic_story_icon_24dp, | |||
secondaryIcon = R.drawable.ic_pages_white_24dp, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for listing so many pieces of related code that I hadn't noticed. It looks fantastic.
Additional code removal suggestions on top of #20016
To Test:
See #20016
Regression Notes
Potential unintended areas of impact
What I did to test those areas of impact (or what existing automated tests I relied on)
What automated tests I added (or what prevented me from doing so)
PR Submission Checklist:
RELEASE-NOTES.txt
if necessary.Testing Checklist: