Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Reader] Scroll post list to top when Reader tab is tapped #20544

Merged

Conversation

RenanLukas
Copy link
Contributor

Fixes #15175


To Test:

  1. Install JP and sign in.
  2. Open Reader.
  3. 馃攳 Open different feeds, scroll down to any point and tap the "Reader" tab in bottom navigation: the list should be scrolled to top and AppBar should be expanded.

Regression Notes

  1. Potential unintended areas of impact

    • None
  2. What I did to test those areas of impact (or what existing automated tests I relied on)

    • Manual testing
  3. What automated tests I added (or what prevented me from doing so)

    --


PR Submission Checklist:

  • I have completed the Regression Notes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

Testing Checklist (strike-out the not-applying and unnecessary ones):

  • WordPress.com sites and self-hosted Jetpack sites.
  • Portrait and landscape orientations.
  • Light and dark modes.
  • Fonts: Larger, smaller and bold text.
  • High contrast.
  • Talkback.
  • Languages with large words or with letters/accents not frequently used in English.
  • Right-to-left languages. (Even if translation isn鈥檛 complete, formatting should still respect the right-to-left layout)
  • Large and small screen sizes. (Tablet and smaller phones)
  • Multi-tasking: Split screen and Pop-up view. (Android 10 or higher)

@dangermattic
Copy link
Collaborator

dangermattic commented Mar 27, 2024

1 Warning
鈿狅笍 PR is not assigned to a milestone.

Generated by 馃毇 Danger

@RenanLukas RenanLukas marked this pull request as ready for review March 27, 2024 18:06
Copy link

sonarcloud bot commented Mar 27, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@wpmobilebot
Copy link
Contributor

WordPress馃摬 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.
App NameWordPress WordPress
FlavorJalapeno
Build TypeDebug
Versionpr20544-00e8f7f
Commit00e8f7f
Direct Downloadwordpress-prototype-build-pr20544-00e8f7f.apk
Note: Google Login is not supported on these builds.

@wpmobilebot
Copy link
Contributor

Jetpack馃摬 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.
App NameJetpack Jetpack
FlavorJalapeno
Build TypeDebug
Versionpr20544-00e8f7f
Commit00e8f7f
Direct Downloadjetpack-prototype-build-pr20544-00e8f7f.apk
Note: Google Login is not supported on these builds.

Copy link
Contributor

@daniloercoli daniloercoli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job! I'm like this feature a lot.

Should we implement the scroll to top functionality on other screens as well?
cc @osullivanchris
Specifically, the Notifications screen, as users often scroll to the bottom of it. (Maybe implement it on My Site as well the other 2 screens?).

@RenanLukas RenanLukas merged commit 084b2c5 into trunk Mar 28, 2024
23 checks passed
@RenanLukas RenanLukas deleted the issue/15175-reader-scroll-to-top-when-tab-is-tapped branch March 28, 2024 14:19
@osullivanchris
Copy link

per our hangout I'm keen to have this on other tabs as well.

FYI this also came up within comments (which may now be at the bottom of a reader view in future) - which is slightly trickier to solve, as its not at the root level so can't solve by tapping the bottom tab bar.

I was playing around with this today where the title of the post would collapse into the navigation bar, and be tappable to scroll to the top. I don't love it yet though.

Screenshot 2024-03-28 at 16 08 10

I also tried with a bit of UI at the bottom of the screen but it was a bit heavy.

Screenshot 2024-03-28 at 16 09 17

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reader: Tapping the icon/tab should scroll to top
5 participants