-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new Subscribers tab #20685
Add new Subscribers tab #20685
Conversation
Generated by 🚫 Danger |
…-Android into origin/issue/20680-new-subscribers-tab
|
App Name | ![]() |
|
Flavor | Jalapeno | |
Build Type | Debug | |
Version | pr20685-2112f8f | |
Commit | 2112f8f | |
Direct Download | wordpress-prototype-build-pr20685-2112f8f.apk |
|
App Name | ![]() |
|
Flavor | Jalapeno | |
Build Type | Debug | |
Version | pr20685-2112f8f | |
Commit | 2112f8f | |
Direct Download | jetpack-prototype-build-pr20685-2112f8f.apk |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## trunk #20685 +/- ##
==========================================
- Coverage 40.63% 40.62% -0.01%
==========================================
Files 1485 1485
Lines 68288 68307 +19
Branches 11296 11296
==========================================
+ Hits 27746 27748 +2
- Misses 38029 38046 +17
Partials 2513 2513 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I corrected a copy&paste mistake (2112f8f).
LGTM! 👍🏻 Good decision to leave other stuff related to use cases to the following PRs.
|
I'm merging but I want to remind you that you can complete the "Regression Notes", "PR Submission Checklist" and "Testing Checklist" sections after the merge, @aditi-bhatia. |
Thank you for the reminder! I've gone ahead and updated those sections. |
Fixes #20680
This PR adds in some basic groundwork for the new Subscribers tab, which is feature flagged behind
stats_traffic_subscribers_tab
. It is currently usingmapInsights
fromUiModelMapper.kt
as a placeholder for now, which is why you will see the screen below:I've left the uses cases empty for now as that work can be done in a separate PR.
To Test:
stats_traffic_subscribers_tab
feature flag on, ensure you see theSubscribers
tab as it appears in the screenshot above.Subscribers
tab should fire thestats_subscribers_accessed
tracked event.stats_traffic_subscribers_tab
feature flag off, ensure you don't see theSubscribers
tab and theweeks/days/months
tabs appear as expected.Regression Notes
Potential unintended areas of impact
stats_traffic_subscribers_tab
feature flagWhat I did to test those areas of impact (or what existing automated tests I relied on)
What automated tests I added (or what prevented me from doing so)
PR Submission Checklist:
RELEASE-NOTES.txt
if necessary.Testing Checklist (strike-out the not-applying and unnecessary ones):
WordPress.com sites and self-hosted Jetpack sites.Portrait and landscape orientations.Light and dark modes.Fonts: Larger, smaller and bold text.High contrast.Talkback.Languages with large words or with letters/accents not frequently used in English.Right-to-left languages. (Even if translation isn’t complete, formatting should still respect the right-to-left layout)Large and small screen sizes. (Tablet and smaller phones)Multi-tasking: Split screen and Pop-up view. (Android 10 or higher)