Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new Subscribers tab #20685

Merged
merged 12 commits into from
Apr 23, 2024
Merged

Add new Subscribers tab #20685

merged 12 commits into from
Apr 23, 2024

Conversation

aditi-bhatia
Copy link
Contributor

@aditi-bhatia aditi-bhatia commented Apr 19, 2024

Fixes #20680

This PR adds in some basic groundwork for the new Subscribers tab, which is feature flagged behind stats_traffic_subscribers_tab. It is currently using mapInsights from UiModelMapper.kt as a placeholder for now, which is why you will see the screen below:

Screenshot 2024-04-22 at 4 43 22 PM

I've left the uses cases empty for now as that work can be done in a separate PR.


To Test:

  1. With the stats_traffic_subscribers_tab feature flag on, ensure you see the Subscribers tab as it appears in the screenshot above.
  2. Accessing the Subscribers tab should fire the stats_subscribers_accessed tracked event.
  3. With the stats_traffic_subscribers_tab feature flag off, ensure you don't see the Subscribers tab and the weeks/days/months tabs appear as expected.

Regression Notes

  1. Potential unintended areas of impact

    • States related to the stats_traffic_subscribers_tab feature flag
  2. What I did to test those areas of impact (or what existing automated tests I relied on)

    • Manual testing
  3. What automated tests I added (or what prevented me from doing so)

    • Tests will be updated in future PRs as development continues

PR Submission Checklist:

  • I have completed the Regression Notes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

Testing Checklist (strike-out the not-applying and unnecessary ones):

  • WordPress.com sites and self-hosted Jetpack sites.
  • Portrait and landscape orientations.
  • Light and dark modes.
  • Fonts: Larger, smaller and bold text.
  • High contrast.
  • Talkback.
  • Languages with large words or with letters/accents not frequently used in English.
  • Right-to-left languages. (Even if translation isn’t complete, formatting should still respect the right-to-left layout)
  • Large and small screen sizes. (Tablet and smaller phones)
  • Multi-tasking: Split screen and Pop-up view. (Android 10 or higher)

@dangermattic
Copy link
Collaborator

2 Warnings
⚠️ strings.xml files should only be updated on release branches, when the translations are downloaded by our automation.
⚠️ PR is not assigned to a milestone.

Generated by 🚫 Danger

@wpmobilebot
Copy link
Contributor

wpmobilebot commented Apr 22, 2024

WordPress📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.
App NameWordPress WordPress
FlavorJalapeno
Build TypeDebug
Versionpr20685-2112f8f
Commit2112f8f
Direct Downloadwordpress-prototype-build-pr20685-2112f8f.apk
Note: Google Login is not supported on these builds.

@wpmobilebot
Copy link
Contributor

wpmobilebot commented Apr 22, 2024

Jetpack📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.
App NameJetpack Jetpack
FlavorJalapeno
Build TypeDebug
Versionpr20685-2112f8f
Commit2112f8f
Direct Downloadjetpack-prototype-build-pr20685-2112f8f.apk
Note: Google Login is not supported on these builds.

Copy link

codecov bot commented Apr 23, 2024

Codecov Report

Attention: Patch coverage is 10.52632% with 17 lines in your changes are missing coverage. Please review.

Project coverage is 40.62%. Comparing base (ed25d7d) to head (2112f8f).

Files Patch % Lines
...droid/ui/stats/refresh/lists/StatsListViewModel.kt 6.66% 14 Missing ⚠️
...rdpress/android/ui/stats/refresh/StatsViewModel.kt 0.00% 2 Missing ⚠️
.../wordpress/android/ui/stats/refresh/StatsModule.kt 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##            trunk   #20685      +/-   ##
==========================================
- Coverage   40.63%   40.62%   -0.01%     
==========================================
  Files        1485     1485              
  Lines       68288    68307      +19     
  Branches    11296    11296              
==========================================
+ Hits        27746    27748       +2     
- Misses      38029    38046      +17     
  Partials     2513     2513              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@irfano irfano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I corrected a copy&paste mistake (2112f8f).
LGTM! 👍🏻 Good decision to leave other stuff related to use cases to the following PRs.

Copy link

sonarcloud bot commented Apr 23, 2024

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@irfano irfano merged commit 18d104c into trunk Apr 23, 2024
20 checks passed
@irfano irfano deleted the origin/issue/20680-new-subscribers-tab branch April 23, 2024 11:22
@irfano
Copy link
Member

irfano commented Apr 23, 2024

I'm merging but I want to remind you that you can complete the "Regression Notes", "PR Submission Checklist" and "Testing Checklist" sections after the merge, @aditi-bhatia.

@aditi-bhatia
Copy link
Contributor Author

Thank you for the reminder! I've gone ahead and updated those sections.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add new Subscribers tab
4 participants