-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactors NoteBlock to Kotlin #20711
Refactors NoteBlock to Kotlin #20711
Conversation
Generated by 🚫 Danger |
📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.
|
📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for making these refactors, it makes the foundation of codebase better. I've tested in different kinds of notifications, everything works as expected. LGTM
It seems that our CI/CD is unstable, I gonna re-run the task, please feel free to merge it after the build is done.
Thank you for reviewing @jarvislin 🙇
I'll run the tests again and if they fail I'll check if any change was introduced with the code. It's weird that #20713 passed the CI checks with the 1st attempt 🤔 |
This should be fixed with 9fd9d9a thank you for the tip @jarvislin 🙇 |
Quality Gate passedIssues Measures |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## feature/notifications_refresh_p2 #20711 +/- ##
====================================================================
+ Coverage 40.64% 40.65% +0.01%
====================================================================
Files 1485 1485
Lines 68315 68285 -30
Branches 11295 11294 -1
====================================================================
Hits 27764 27764
+ Misses 38038 38008 -30
Partials 2513 2513 ☔ View full report in Codecov by Sentry. |
Description
As an initial step towards the Milestone screen revamp this PR refactors some of the related code to Kotlin.
To Test:
Regression Notes
Potential unintended areas of impact
What I did to test those areas of impact (or what existing automated tests I relied on)
What automated tests I added (or what prevented me from doing so)
PR Submission Checklist:
RELEASE-NOTES.txt
if necessary.Testing Checklist (strike-out the not-applying and unnecessary ones):