Add Total Subscribers card to Subscribers tab #20732
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generated by 🚫 Danger |
aditi-bhatia
changed the title
…-Android into origin/issue/add-total-subscribers
|
 |
App Name |  Jetpack |
| Flavor | Jalapeno | |
| Build Type | Debug | |
| Version | pr20732-954d593 | |
| Commit | 954d593 | |
| Direct Download | jetpack-prototype-build-pr20732-954d593.apk |
|
 |
App Name |  WordPress |
| Flavor | Jalapeno | |
| Build Type | Debug | |
| Version | pr20732-954d593 | |
| Commit | 954d593 | |
| Direct Download | wordpress-prototype-build-pr20732-954d593.apk |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## trunk #20732 +/- ##
=======================================
Coverage 40.67% 40.67%
=======================================
Files 1490 1491 +1
Lines 68616 68651 +35
Branches 11337 11342 +5
=======================================
+ Hits 27909 27927 +18
- Misses 38173 38187 +14
- Partials 2534 2537 +3 ☔ View full report in Codecov by Sentry. |
…-Android into origin/issue/add-total-subscribers
irfano
requested changes
May 1, 2024
WordPress/src/main/java/org/wordpress/android/ui/stats/refresh/StatsModule.kt
Outdated
Show resolved
Hide resolved
...ress/android/ui/stats/refresh/lists/sections/subscribers/usecases/TotalSubscribersUseCase.kt
Show resolved
Hide resolved
...ress/android/ui/stats/refresh/lists/sections/subscribers/usecases/TotalSubscribersUseCase.kt
Outdated
Show resolved
Hide resolved
...ress/android/ui/stats/refresh/lists/sections/subscribers/usecases/TotalSubscribersUseCase.kt
Outdated
Show resolved
Hide resolved
|
I want to remind you
|
…-Android into origin/issue/add-total-subscribers
…-Android into origin/issue/add-total-subscribers
irfano
force-pushed
the
origin/issue/add-total-subscribers
branch
from
a2965bc
to
954d593
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #20692
This PR adds the Total Subscribers card to the Subscribers tab:
Note: see outstanding questions thread here: p1714493430782359-slack-C06BR07TJHK.
To Test:
stats_traffic_subscribers_tabfrom My Site → Debug settings.Regression Notes
Potential unintended areas of impact
What I did to test those areas of impact (or what existing automated tests I relied on)
What automated tests I added (or what prevented me from doing so)
PR Submission Checklist:
RELEASE-NOTES.txtif necessary.Testing Checklist (strike-out the not-applying and unnecessary ones):
- [ ] WordPress.com sites and self-hosted Jetpack sites.- [ ] Languages with large words or with letters/accents not frequently used in English.- [ ] Right-to-left languages. (Even if translation isn’t complete, formatting should still respect the right-to-left layout)