-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Total Subscribers card to Subscribers tab #20732
Conversation
Generated by 🚫 Danger |
…-Android into origin/issue/add-total-subscribers
|
App Name | ![]() |
|
Flavor | Jalapeno | |
Build Type | Debug | |
Version | pr20732-954d593 | |
Commit | 954d593 | |
Direct Download | jetpack-prototype-build-pr20732-954d593.apk |
|
App Name | ![]() |
|
Flavor | Jalapeno | |
Build Type | Debug | |
Version | pr20732-954d593 | |
Commit | 954d593 | |
Direct Download | wordpress-prototype-build-pr20732-954d593.apk |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## trunk #20732 +/- ##
=======================================
Coverage 40.67% 40.67%
=======================================
Files 1490 1491 +1
Lines 68616 68651 +35
Branches 11337 11342 +5
=======================================
+ Hits 27909 27927 +18
- Misses 38173 38187 +14
- Partials 2534 2537 +3 ☔ View full report in Codecov by Sentry. |
…-Android into origin/issue/add-total-subscribers
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job, the card works well! I have just added minor comments related to the code.
WordPress/src/main/java/org/wordpress/android/ui/stats/refresh/StatsModule.kt
Outdated
Show resolved
Hide resolved
...ress/android/ui/stats/refresh/lists/sections/subscribers/usecases/TotalSubscribersUseCase.kt
Show resolved
Hide resolved
...ress/android/ui/stats/refresh/lists/sections/subscribers/usecases/TotalSubscribersUseCase.kt
Outdated
Show resolved
Hide resolved
...ress/android/ui/stats/refresh/lists/sections/subscribers/usecases/TotalSubscribersUseCase.kt
Outdated
Show resolved
Hide resolved
I want to remind you
|
…-Android into origin/issue/add-total-subscribers
…-Android into origin/issue/add-total-subscribers
a2965bc
to
954d593
Compare
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for addressing my comments. I have fixed a failing unit test (954d593).
LGTM! 👍🏻
Fixes #20692
This PR adds the Total Subscribers card to the Subscribers tab:
Note: see outstanding questions thread here: p1714493430782359-slack-C06BR07TJHK.
To Test:
stats_traffic_subscribers_tab
from My Site → Debug settings.Regression Notes
Potential unintended areas of impact
What I did to test those areas of impact (or what existing automated tests I relied on)
What automated tests I added (or what prevented me from doing so)
PR Submission Checklist:
RELEASE-NOTES.txt
if necessary.Testing Checklist (strike-out the not-applying and unnecessary ones):
- [ ] WordPress.com sites and self-hosted Jetpack sites.- [ ] Languages with large words or with letters/accents not frequently used in English.- [ ] Right-to-left languages. (Even if translation isn’t complete, formatting should still respect the right-to-left layout)