-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Tags Feed] Lazy load tag rows #20790
Conversation
…ss-Android into issue/20708-tags-feed-lazy-load
📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.
|
📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## feature/tags-ia #20790 +/- ##
================================================
Coverage 40.78% 40.78%
================================================
Files 1493 1493
Lines 68611 68625 +14
Branches 11332 11333 +1
================================================
+ Hits 27984 27991 +7
- Misses 38086 38093 +7
Partials 2541 2541 ☔ View full report in Codecov by Sentry. |
...src/main/java/org/wordpress/android/ui/reader/viewmodels/tagsfeed/ReaderTagsFeedViewModel.kt
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a minor comment, but other than that, it looks good to merge!
Quality Gate passedIssues Measures |
Fixes #20708
Add lazy loading to tag rows so the tag posts are only fetched when the tag component is rendered. This avoids loading content that might never be seen by the user.
Also move the execution of fetching the posts for tags to the IO dispatcher.
To Test:
reader_tags_feed
feature config is onRegression Notes
Potential unintended areas of impact
What I did to test those areas of impact (or what existing automated tests I relied on)
What automated tests I added (or what prevented me from doing so)
PR Submission Checklist:
RELEASE-NOTES.txt
if necessary.Testing Checklist (strike-out the not-applying and unnecessary ones):