[Tags Feed] Fix duplicate tracking in Reader subfilter

[thomashorta]

Fixes #20814

• Keep a consistent reference to the SubFilterViewModel observers to leverage the existing Observable APIs, which handle duplicate observation, removal, and re-observation in case of multiple observe call and lifecycle state changes
• Fix sending the reader_filter_sheet_item_selected when selecting a filterable feed (e.g.: Subscriptions and Your Tags)

---

To Test:

1. Install Jetpack
2. Make sure App Setting -> Privacy -> Collect Information is enabled
3. Make sure reader_tags_feed Feature config is enabled (Debug Settings -> Remote Features
4. Go to Reader
5. Go to Subscriptions
6. Verify reader_filter_sheet_item_selected is not tracked
7. Tap the subfilter pill
8. Verify appropriate events are tracked ONLY ONCE
9. Tap a Site
10. Verify reader_filter_sheet_item_selected is tracked ONLY ONCE
11. Tap the pill again
12. Repeat 9-11 multiple times making sure events are tracked ONLY ONCE per trigger
13. Go to Your Tags
14. Repeat 6-12

---

Regression Notes

1. Potential unintended areas of impact

   • N/A

2. What I did to test those areas of impact (or what existing automated tests I relied on)

   • N/A

3. What automated tests I added (or what prevented me from doing so)

   • Unit tests not added for the one-time initialization mechanism since it is done completely in Fragment and ViewModel non-exposed APIs (onCleared)
   • Unit tests updated for bug fix related to sending reader_filter_sheet_item_selected when opening a filterable feed

---

PR Submission Checklist:

• I have completed the Regression Notes.
• I have considered adding accessibility improvements for my changes.
• I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

---

Testing Checklist (strike-out the not-applying and unnecessary ones):

• WordPress.com sites and self-hosted Jetpack sites.
• Portrait and landscape orientations.
• Light and dark modes.
• Fonts: Larger, smaller and bold text.
• High contrast.
• Talkback.
• Languages with large words or with letters/accents not frequently used in English.
• Right-to-left languages. (Even if translation isn’t complete, formatting should still respect the right-to-left layout)
• Large and small screen sizes. (Tablet and smaller phones)
• Multi-tasking: Split screen and Pop-up view. (Android 10 or higher)

[wpmobilebot]

📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.

	App Name	WordPress
	Flavor	Jalapeno
	Build Type	Debug
	Version	pr20844-12e9ef7
	Commit	12e9ef7
	Direct Download	wordpress-prototype-build-pr20844-12e9ef7.apk

Note: Google Login is not supported on these builds.

[wpmobilebot]

📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.

	App Name	Jetpack
	Flavor	Jalapeno
	Build Type	Debug
	Version	pr20844-12e9ef7
	Commit	12e9ef7
	Direct Download	jetpack-prototype-build-pr20844-12e9ef7.apk

Note: Google Login is not supported on these builds.

[codecov]

Codecov Report

Attention: Patch coverage is 76.92308% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 40.88%. Comparing base (06d79f6) to head (12e9ef7).

Files	Patch %	Lines
.../android/ui/reader/subfilter/SubFilterViewModel.kt	76.92%	2 Missing and 1 partial ⚠️

Additional details and impacted files

@@                 Coverage Diff                 @@
##           feature/tags-ia   #20844      +/-   ##
===================================================
+ Coverage            40.84%   40.88%   +0.04%     
===================================================
  Files                 1493     1493              
  Lines                68766    68770       +4     
  Branches             11350    11350              
===================================================
+ Hits                 28087    28117      +30     
+ Misses               38131    38098      -33     
- Partials              2548     2555       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[daniloercoli]

LGTM!
While testing this PR i've found a bug in the top menu. We will discuss it on Slack before opening a new ticket for it.

[thomashorta]

I tested the scenarios we discussed on Slack and indeed the solution here doesn't seem to be working correctly for some of them. I'm marking the PR as Not Ready for Merge and Not Ready for Review while I think of a different solution. Thanks for the review @daniloercoli !

[thomashorta]

@daniloercoli, to fix the issue I needed to radically change the solution. The new solution properly uses the observable mechanism by creating a local reference to the Observers, which prevents duplicate observation by default (thanks to the "Observer, LifecycleOwner" tuple being stable and consistent now), and also handles lifecycle and view model state changes automatically.

Please review again with the new changes!

[daniloercoli]

which prevents duplicate observation by default (thanks to the "Observer, LifecycleOwner" tuple being stable and consistent now), and also handles lifecycle and view model state changes automatically.

Tested and cannot replicate the issue anymore! Code looks robust, and adheres to good practices with regard to ViewModel and lifecycle management. LGTM!

[daniloercoli]

Feel free to merge this PR, once the problems with testes are resolved.

[sonarcloud]

Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

[sentry-io]

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

• ‼️ IllegalArgumentException: Tried to schedule job for non-existent component: ComponentInfo{com.jetpack.android/org.wordpress... org.wordpress.android.ui.reader.services.update... View Issue

_{Did you find this useful? React with a 👍 or 👎}