-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set targetSdk to 34. #20854
Set targetSdk to 34. #20854
Conversation
Hey @geriux I tried to reproduce crashing when uploading media through gutenberg and media files. Could not get a crash on a api 34 device. Tried a pre api 34 device. No crash. Mind giving me exact steps to cause a crash? |
📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.
|
📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.
|
Hey there! The crash is no longer happening I guess because of this change #20838 I've tested the builds from this PR. By the way, the |
Requesting 2 approvals @irfano and @AjeshRPai . Once we get the approvals, Ajesh can merge once the declaration is finalized. |
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍🏻 I tested the items you listed on an Android 14 emulator, and they all worked as expected. We have already discussed the required changes for Android 14.
PR description includes Fixes #19917
but let's not forget the last item in the issue: Add foreground service declaration to Playstore
.
@AjeshRPai just need the quick test and approval from you. Or I guess let me know when you want to merge it so it's tied to the play console documents we need to submit |
Hey @notandyvee |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @notandyvee
I tested the following scenario's on both Android 13 and Android 14, and everything looks good to me 👍🏼
- Uploading images through gutenberg
- Uploading images through wordpress media
- Delete media from wordpress.com media.
- Make a post and edit a post.
- Use the reader.
- Comment on a post.
- Like a post.
- Notifications should work.
- Create a site.
- Test widgets.
Approving and merging the PR
Revert "Merge pull request #20854 from wordpress-mobile/andy/target-s…
Fixes #19917
This PR updates the
targetSdk
from 33 to 34.To Test:
Regression Notes
Potential unintended areas of impact
Core services like media, posting, notifications. We've tested a lot though.
What I did to test those areas of impact (or what existing automated tests I relied on)
Manual testing.
What automated tests I added (or what prevented me from doing so)
N/A
PR Submission Checklist:
RELEASE-NOTES.txt
if necessary.