Set targetSdk to 34.

[notandyvee]

Fixes #19917

This PR updates the targetSdk from 33 to 34.

---

To Test:

• Uploading images through gutenberg
• Uploading images through wordpress media
• Delete media from wordpress.com media.
• Make a post and edit a post.
• Use the reader.
• Comment on a post.
• Like a post.
• Notifications should work.
• Create a site.
• Test widgets.

---

Regression Notes

1. Potential unintended areas of impact

   Core services like media, posting, notifications. We've tested a lot though.

2. What I did to test those areas of impact (or what existing automated tests I relied on)

   Manual testing.

3. What automated tests I added (or what prevented me from doing so)

   N/A

---

PR Submission Checklist:

• I have completed the Regression Notes.
• I have considered adding accessibility improvements for my changes.
• I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

[notandyvee]

Hey @geriux I tried to reproduce crashing when uploading media through gutenberg and media files. Could not get a crash on a api 34 device. Tried a pre api 34 device. No crash. Mind giving me exact steps to cause a crash?

[wpmobilebot]

📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.

	App Name	Jetpack
	Flavor	Jalapeno
	Build Type	Debug
	Version	pr20854-01cf519
	Commit	01cf519
	Direct Download	jetpack-prototype-build-pr20854-01cf519.apk

Note: Google Login is not supported on these builds.

[wpmobilebot]

📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.

	App Name	WordPress
	Flavor	Jalapeno
	Build Type	Debug
	Version	pr20854-01cf519
	Commit	01cf519
	Direct Download	wordpress-prototype-build-pr20854-01cf519.apk

Note: Google Login is not supported on these builds.

[geriux]

Hey @geriux I tried to reproduce crashing when uploading media through gutenberg and media files. Could not get a crash on a api 34 device. Tried a pre api 34 device. No crash. Mind giving me exact steps to cause a crash?

Hey there! The crash is no longer happening I guess because of this change #20838 I've tested the builds from this PR.

By the way, the v1.119.0-alpha2 alpha tag already has the Gutenberg changes for targetSdk 34, so no need to change it to the commit hash 👍

[notandyvee]

Requesting 2 approvals @irfano and @AjeshRPai . Once we get the approvals, Ajesh can merge once the declaration is finalized.

[sonarcloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

[irfano]

👍🏻 I tested the items you listed on an Android 14 emulator, and they all worked as expected. We have already discussed the required changes for Android 14.
PR description includes Fixes #19917 but let's not forget the last item in the issue: Add foreground service declaration to Playstore.

[notandyvee]

@AjeshRPai just need the quick test and approval from you. Or I guess let me know when you want to merge it so it's tied to the play console documents we need to submit

[AjeshRPai]

Hey @notandyvee
I couldn't do the testing today, but I will do it first thing, tomorrow morning. I can take care of the merge as well. But if you need to merge it today itself, feel free to do that, and I will test it from the trunk.

[AjeshRPai]

Hey @notandyvee

I tested the following scenario's on both Android 13 and Android 14, and everything looks good to me 👍🏼

• Uploading images through gutenberg
• Uploading images through wordpress media
• Delete media from wordpress.com media.
• Make a post and edit a post.
• Use the reader.
• Comment on a post.
• Like a post.
• Notifications should work.
• Create a site.
• Test widgets.

Approving and merging the PR