Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Reader] Implement announcement card improvements #20861

Merged

Conversation

RenanLukas
Copy link
Contributor

Fixes #20621

Shows the Reader announcement card just on "Discover" feed and implements the suggestions made by @develric.

Screen.Recording.2024-05-22.at.12.31.20.AM.mov

To Test:

  • Install JP and log in.
  • Make sure the reader_announcement_card feature flag is disabled.
  • Open Reader.
  • 🔍 Verify the announcement card is not shown in any feed.
  • Enable reader_announcement_card feature flag.
  • Open Reader.
  • 🔍 Verify the announcement card appears as expected only on Discover feed.
  • 🔍 Unfollow all tags and open Discover feed: the empty state UI should be shown and the announcement card should be hidden.
  • 🔍 Tap "Done" button: make sure the announcement card disappears and is never shown again (unless the app data is cleared).

Regression Notes

  1. Potential unintended areas of impact

    • None
  2. What I did to test those areas of impact (or what existing automated tests I relied on)

    • Manual testing and updated unit tests
  3. What automated tests I added (or what prevented me from doing so)

    • Updated ReaderViewModelTest.

PR Submission Checklist:

  • I have completed the Regression Notes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

Testing Checklist (strike-out the not-applying and unnecessary ones):

  • WordPress.com sites and self-hosted Jetpack sites.
  • Portrait and landscape orientations.
  • Light and dark modes.
  • Fonts: Larger, smaller and bold text.
  • High contrast.
  • Talkback.
  • Languages with large words or with letters/accents not frequently used in English.
  • Right-to-left languages. (Even if translation isn’t complete, formatting should still respect the right-to-left layout)
  • Large and small screen sizes. (Tablet and smaller phones)
  • Multi-tasking: Split screen and Pop-up view. (Android 10 or higher)

@RenanLukas RenanLukas marked this pull request as ready for review May 22, 2024 04:31
Copy link

sonarcloud bot commented May 22, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@wpmobilebot
Copy link
Contributor

Jetpack📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.
App NameJetpack Jetpack
FlavorJalapeno
Build TypeDebug
Versionpr20861-9d73d4a
Commit9d73d4a
Direct Downloadjetpack-prototype-build-pr20861-9d73d4a.apk
Note: Google Login is not supported on these builds.

@wpmobilebot
Copy link
Contributor

WordPress📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.
App NameWordPress WordPress
FlavorJalapeno
Build TypeDebug
Versionpr20861-9d73d4a
Commit9d73d4a
Direct Downloadwordpress-prototype-build-pr20861-9d73d4a.apk
Note: Google Login is not supported on these builds.

Copy link

codecov bot commented May 22, 2024

Codecov Report

Attention: Patch coverage is 54.54545% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 40.85%. Comparing base (681ab48) to head (9d73d4a).
Report is 19 commits behind head on feature/tags-ia.

Files Patch % Lines
...ss/android/ui/reader/viewmodels/ReaderViewModel.kt 37.50% 2 Missing and 3 partials ⚠️
Additional details and impacted files
@@                 Coverage Diff                 @@
##           feature/tags-ia   #20861      +/-   ##
===================================================
+ Coverage            40.83%   40.85%   +0.01%     
===================================================
  Files                 1494     1494              
  Lines                68771    68780       +9     
  Branches             11349    11352       +3     
===================================================
+ Hits                 28086    28097      +11     
+ Misses               38139    38126      -13     
- Partials              2546     2557      +11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@develric develric left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @RenanLukas 🙇 ! As we discussed we will see if we can look at a way that scales to the other screens as well but this is looking better already 👍 . Approving and merging 🎉

@develric develric merged commit 5644c2b into feature/tags-ia May 22, 2024
23 checks passed
@develric develric deleted the issue/20621-tags-feed-onboarding-improvements branch May 22, 2024 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants