Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix QuickPress shortcut not opening Edit post #20974

Merged
merged 1 commit into from
Jun 12, 2024

Conversation

zwarm
Copy link
Contributor

@zwarm zwarm commented Jun 11, 2024

Fixes #20912

The PR address an issue with setting the site when launching Edit Post from a QuickPress shortcut.


To Test:

Reproduce the issue

  • Install a JP app version other than the one in this PR
  • Log in and select a site
  • Go back to the device's home screen and long tap on the app icon.
  • Select Widgets.
  • Add the QuickPress shortcut to the home screen (be sure to select a site when prompted)
  • Tap on the shortcut.
  • ✅ Verify you see the following error message "An error occurred when accessing this blog, and not opening the posting screen."

Test the fix

  • Install JP from this PR
  • Log in and select a site
  • Go back to the device's home screen and long tap on the app icon.
  • Select Widgets.
  • Add the QuickPress shortcut to the home screen (be sure to select a site when prompted)
  • Tap on the shortcut.
  • ✅ Verify you the app launches and you are taken to the Edit Post view

Note: If you attempt to launch a site connected to QuickPress without being logged into an account with the necessary access, you will see the above error message.


Regression Notes

  1. Potential unintended areas of impact
    The quickpress shortcut does not work as expected

  2. What I did to test those areas of impact (or what existing automated tests I relied on)
    Manual testing

  3. What automated tests I added (or what prevented me from doing so)
    Relied upon existing tests


PR Submission Checklist:

  • I have completed the Regression Notes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

Testing Checklist (strike-out the not-applying and unnecessary ones): N/A

@dangermattic
Copy link
Collaborator

1 Warning
⚠️ PR is not assigned to a milestone.

Generated by 🚫 Danger

Copy link

sonarcloud bot commented Jun 11, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@wpmobilebot
Copy link
Contributor

Jetpack📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.
App NameJetpack Jetpack
FlavorJalapeno
Build TypeDebug
Versionpr20974-98b27b1
Commit98b27b1
Direct Downloadjetpack-prototype-build-pr20974-98b27b1.apk
Note: Google Login is not supported on these builds.

@wpmobilebot
Copy link
Contributor

WordPress📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.
App NameWordPress WordPress
FlavorJalapeno
Build TypeDebug
Versionpr20974-98b27b1
Commit98b27b1
Direct Downloadwordpress-prototype-build-pr20974-98b27b1.apk
Note: Google Login is not supported on these builds.

Copy link
Member

@irfano irfano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I compared the changed line with the line before the conversion in EditPostActivity.java and the diff LGTM! 👍🏻 It fixed the issue.

@irfano irfano merged commit 756cbd8 into trunk Jun 12, 2024
21 checks passed
@irfano irfano deleted the issue/20912-fix-quickpress-shortcut branch June 12, 2024 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

QuickPress shortcut is not working
4 participants