Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update wordPressLoginVersion to 1.16.0 #20993

Merged
merged 1 commit into from
Jun 17, 2024
Merged

Update wordPressLoginVersion to 1.16.0 #20993

merged 1 commit into from
Jun 17, 2024

Conversation

irfano
Copy link
Member

@irfano irfano commented Jun 17, 2024

Fixes #19561

This updates the WordPress-Login-Flow-Android version to 1.16.0. The new version includes only a fix for #19561.

@irfano irfano added this to the 25.2 milestone Jun 17, 2024
@irfano irfano requested a review from staskus June 17, 2024 11:36
Copy link

sonarcloud bot commented Jun 17, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@wpmobilebot
Copy link
Contributor

Found 1 violations:

The PR caused some dependency changes (expand to see details)

-+--- org.wordpress:login:1.15.0
-|    +--- androidx.appcompat:appcompat:1.6.1 (*)
-|    +--- androidx.vectordrawable:vectordrawable-animated:1.1.0 (*)
-|    +--- androidx.media:media:1.2.1 (*)
-|    +--- androidx.legacy:legacy-support-v13:1.0.0
-|    |    \--- androidx.legacy:legacy-support-v4:1.0.0 (*)
-|    +--- androidx.gridlayout:gridlayout:1.0.0 (*)
-|    +--- androidx.constraintlayout:constraintlayout:2.0.4 -> 2.1.4 (*)
-|    +--- com.google.android.material:material:1.2.1 -> 1.9.0 (*)
-|    +--- androidx.core:core-ktx:1.12.0 (*)
-|    +--- org.wordpress:fluxc:trunk-ed60798b4d96ec19863c74b0f525e2e20f4525db -> trunk-0fe67fa241426afeaaa66bc3970ba46634efa5c8 (*)
-|    +--- androidx.credentials:credentials:1.2.0
-|    |    +--- androidx.annotation:annotation:1.5.0 -> 1.6.0 (*)
-|    |    +--- org.jetbrains.kotlin:kotlin-stdlib:1.8.22 -> 1.9.22 (*)
-|    |    +--- org.jetbrains.kotlinx:kotlinx-coroutines-core:1.7.1 -> 1.7.3 (*)
-|    |    \--- androidx.credentials:credentials-play-services-auth:1.2.0 (c)
-|    +--- androidx.credentials:credentials-play-services-auth:1.2.0
-|    |    +--- androidx.credentials:credentials:1.2.0 (*)
-|    |    +--- com.google.android.gms:play-services-auth:20.7.0
-|    |    |    +--- androidx.fragment:fragment:1.0.0 -> 1.6.2 (*)
-|    |    |    +--- androidx.loader:loader:1.0.0 (*)
-|    |    |    +--- com.google.android.gms:play-services-auth-api-phone:18.0.1
-|    |    |    |    +--- com.google.android.gms:play-services-base:18.0.1 -> 18.1.0
-|    |    |    |    |    +--- androidx.collection:collection:1.0.0 -> 1.2.0 (*)
-|    |    |    |    |    +--- androidx.core:core:1.2.0 -> 1.12.0 (*)
-|    |    |    |    |    +--- androidx.fragment:fragment:1.0.0 -> 1.6.2 (*)
-|    |    |    |    |    +--- com.google.android.gms:play-services-basement:18.1.0 -> 18.2.0
-|    |    |    |    |    |    +--- androidx.collection:collection:1.0.0 -> 1.2.0 (*)
-|    |    |    |    |    |    +--- androidx.core:core:1.2.0 -> 1.12.0 (*)
-|    |    |    |    |    |    \--- androidx.fragment:fragment:1.0.0 -> 1.6.2 (*)
-|    |    |    |    |    \--- com.google.android.gms:play-services-tasks:18.0.2
-|    |    |    |    |         \--- com.google.android.gms:play-services-basement:18.1.0 -> 18.2.0 (*)
-|    |    |    |    +--- com.google.android.gms:play-services-basement:18.0.0 -> 18.2.0 (*)
-|    |    |    |    \--- com.google.android.gms:play-services-tasks:18.0.1 -> 18.0.2 (*)
-|    |    |    +--- com.google.android.gms:play-services-auth-base:18.0.4
-|    |    |    |    +--- androidx.collection:collection:1.0.0 -> 1.2.0 (*)
-|    |    |    |    +--- com.google.android.gms:play-services-base:18.0.1 -> 18.1.0 (*)
-|    |    |    |    +--- com.google.android.gms:play-services-basement:18.0.0 -> 18.2.0 (*)
-|    |    |    |    \--- com.google.android.gms:play-services-tasks:18.0.1 -> 18.0.2 (*)
-|    |    |    +--- com.google.android.gms:play-services-base:18.0.1 -> 18.1.0 (*)
-|    |    |    +--- com.google.android.gms:play-services-basement:18.2.0 (*)
-|    |    |    +--- com.google.android.gms:play-services-fido:20.0.1 -> 20.1.0
-|    |    |    |    +--- com.google.android.gms:play-services-base:18.0.1 -> 18.1.0 (*)
-|    |    |    |    +--- com.google.android.gms:play-services-basement:18.0.0 -> 18.2.0 (*)
-|    |    |    |    \--- com.google.android.gms:play-services-tasks:18.0.1 -> 18.0.2 (*)
-|    |    |    \--- com.google.android.gms:play-services-tasks:18.0.1 -> 18.0.2 (*)
-|    |    +--- com.google.android.gms:play-services-fido:20.1.0 (*)
-|    |    +--- com.google.android.libraries.identity.googleid:googleid:1.1.0
-|    |    |    +--- org.jetbrains.kotlin:kotlin-stdlib:1.8.0 -> 1.9.22 (*)
-|    |    |    \--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.8.0 -> 1.9.10 (*)
-|    |    +--- org.jetbrains.kotlin:kotlin-stdlib:1.8.22 -> 1.9.22 (*)
-|    |    \--- androidx.credentials:credentials:1.2.0 (c)
-|    +--- com.google.dagger:dagger:2.47 -> 2.50 (*)
-|    +--- com.google.dagger:dagger-android-support:2.47 -> 2.50
-|    |    +--- com.google.dagger:dagger:2.50 (*)
-|    |    +--- com.google.dagger:dagger-android:2.50
-|    |    |    +--- com.google.dagger:dagger:2.50 (*)
-|    |    |    +--- com.google.dagger:dagger-lint-aar:2.50
-|    |    |    +--- androidx.annotation:annotation:1.2.0 -> 1.6.0 (*)
-|    |    |    \--- javax.inject:javax.inject:1
-|    |    +--- com.google.dagger:dagger-lint-aar:2.50
-|    |    +--- androidx.activity:activity:1.5.1 -> 1.8.0 (*)
-|    |    +--- androidx.annotation:annotation:1.2.0 -> 1.6.0 (*)
-|    |    +--- androidx.appcompat:appcompat:1.3.1 -> 1.6.1 (*)
-|    |    +--- androidx.fragment:fragment:1.5.1 -> 1.6.2 (*)
-|    |    +--- androidx.lifecycle:lifecycle-common:2.5.1 -> 2.6.2 (*)
-|    |    +--- androidx.lifecycle:lifecycle-viewmodel:2.5.1 -> 2.6.2 (*)
-|    |    +--- androidx.lifecycle:lifecycle-viewmodel-savedstate:2.5.1 -> 2.6.2 (*)
-|    |    \--- javax.inject:javax.inject:1
-|    +--- com.google.android.gms:play-services-auth:18.1.0 -> 20.7.0 (*)
-|    \--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.8.0 -> 1.9.10 (*)
++--- org.wordpress:login:1.16.0
+|    +--- com.gravatar:gravatar:0.2.0 -> 1.0.0
+|    |    +--- com.squareup.retrofit2:retrofit:2.9.0
+|    |    |    \--- com.squareup.okhttp3:okhttp:3.14.9 -> 4.12.0 (*)
+|    |    +--- com.squareup.retrofit2:converter-gson:2.9.0
+|    |    |    +--- com.squareup.retrofit2:retrofit:2.9.0 (*)
+|    |    |    \--- com.google.code.gson:gson:2.8.5 -> 2.10.1
+|    |    +--- org.jetbrains.kotlinx:kotlinx-coroutines-android:1.7.3 (*)
+|    |    +--- com.squareup.okhttp3:okhttp:4.12.0 (*)
+|    |    \--- org.jetbrains.kotlin:kotlin-stdlib:1.9.22 (*)
+|    +--- androidx.appcompat:appcompat:1.6.1 (*)
+|    +--- androidx.vectordrawable:vectordrawable-animated:1.1.0 (*)
+|    +--- androidx.media:media:1.2.1 (*)
+|    +--- androidx.legacy:legacy-support-v13:1.0.0
+|    |    \--- androidx.legacy:legacy-support-v4:1.0.0 (*)
+|    +--- androidx.gridlayout:gridlayout:1.0.0 (*)
+|    +--- androidx.constraintlayout:constraintlayout:2.0.4 -> 2.1.4 (*)
+|    +--- com.google.android.material:material:1.2.1 -> 1.9.0 (*)
+|    +--- androidx.core:core-ktx:1.12.0 (*)
+|    +--- org.wordpress:fluxc:trunk-ed60798b4d96ec19863c74b0f525e2e20f4525db -> trunk-0fe67fa241426afeaaa66bc3970ba46634efa5c8 (*)
+|    +--- androidx.credentials:credentials:1.2.0
+|    |    +--- androidx.annotation:annotation:1.5.0 -> 1.6.0 (*)
+|    |    +--- org.jetbrains.kotlin:kotlin-stdlib:1.8.22 -> 1.9.22 (*)
+|    |    +--- org.jetbrains.kotlinx:kotlinx-coroutines-core:1.7.1 -> 1.7.3 (*)
+|    |    \--- androidx.credentials:credentials-play-services-auth:1.2.0 (c)
+|    +--- androidx.credentials:credentials-play-services-auth:1.2.0
+|    |    +--- androidx.credentials:credentials:1.2.0 (*)
+|    |    +--- com.google.android.gms:play-services-auth:20.7.0
+|    |    |    +--- androidx.fragment:fragment:1.0.0 -> 1.6.2 (*)
+|    |    |    +--- androidx.loader:loader:1.0.0 (*)
+|    |    |    +--- com.google.android.gms:play-services-auth-api-phone:18.0.1
+|    |    |    |    +--- com.google.android.gms:play-services-base:18.0.1 -> 18.1.0
+|    |    |    |    |    +--- androidx.collection:collection:1.0.0 -> 1.2.0 (*)
+|    |    |    |    |    +--- androidx.core:core:1.2.0 -> 1.12.0 (*)
+|    |    |    |    |    +--- androidx.fragment:fragment:1.0.0 -> 1.6.2 (*)
+|    |    |    |    |    +--- com.google.android.gms:play-services-basement:18.1.0 -> 18.2.0
+|    |    |    |    |    |    +--- androidx.collection:collection:1.0.0 -> 1.2.0 (*)
+|    |    |    |    |    |    +--- androidx.core:core:1.2.0 -> 1.12.0 (*)
+|    |    |    |    |    |    \--- androidx.fragment:fragment:1.0.0 -> 1.6.2 (*)
+|    |    |    |    |    \--- com.google.android.gms:play-services-tasks:18.0.2
+|    |    |    |    |         \--- com.google.android.gms:play-services-basement:18.1.0 -> 18.2.0 (*)
+|    |    |    |    +--- com.google.android.gms:play-services-basement:18.0.0 -> 18.2.0 (*)
+|    |    |    |    \--- com.google.android.gms:play-services-tasks:18.0.1 -> 18.0.2 (*)
+|    |    |    +--- com.google.android.gms:play-services-auth-base:18.0.4
+|    |    |    |    +--- androidx.collection:collection:1.0.0 -> 1.2.0 (*)
+|    |    |    |    +--- com.google.android.gms:play-services-base:18.0.1 -> 18.1.0 (*)
+|    |    |    |    +--- com.google.android.gms:play-services-basement:18.0.0 -> 18.2.0 (*)
+|    |    |    |    \--- com.google.android.gms:play-services-tasks:18.0.1 -> 18.0.2 (*)
+|    |    |    +--- com.google.android.gms:play-services-base:18.0.1 -> 18.1.0 (*)
+|    |    |    +--- com.google.android.gms:play-services-basement:18.2.0 (*)
+|    |    |    +--- com.google.android.gms:play-services-fido:20.0.1 -> 20.1.0
+|    |    |    |    +--- com.google.android.gms:play-services-base:18.0.1 -> 18.1.0 (*)
+|    |    |    |    +--- com.google.android.gms:play-services-basement:18.0.0 -> 18.2.0 (*)
+|    |    |    |    \--- com.google.android.gms:play-services-tasks:18.0.1 -> 18.0.2 (*)
+|    |    |    \--- com.google.android.gms:play-services-tasks:18.0.1 -> 18.0.2 (*)
+|    |    +--- com.google.android.gms:play-services-fido:20.1.0 (*)
+|    |    +--- com.google.android.libraries.identity.googleid:googleid:1.1.0
+|    |    |    +--- org.jetbrains.kotlin:kotlin-stdlib:1.8.0 -> 1.9.22 (*)
+|    |    |    \--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.8.0 -> 1.9.10 (*)
+|    |    +--- org.jetbrains.kotlin:kotlin-stdlib:1.8.22 -> 1.9.22 (*)
+|    |    \--- androidx.credentials:credentials:1.2.0 (c)
+|    +--- com.google.dagger:dagger:2.47 -> 2.50 (*)
+|    +--- com.google.dagger:dagger-android-support:2.47 -> 2.50
+|    |    +--- com.google.dagger:dagger:2.50 (*)
+|    |    +--- com.google.dagger:dagger-android:2.50
+|    |    |    +--- com.google.dagger:dagger:2.50 (*)
+|    |    |    +--- com.google.dagger:dagger-lint-aar:2.50
+|    |    |    +--- androidx.annotation:annotation:1.2.0 -> 1.6.0 (*)
+|    |    |    \--- javax.inject:javax.inject:1
+|    |    +--- com.google.dagger:dagger-lint-aar:2.50
+|    |    +--- androidx.activity:activity:1.5.1 -> 1.8.0 (*)
+|    |    +--- androidx.annotation:annotation:1.2.0 -> 1.6.0 (*)
+|    |    +--- androidx.appcompat:appcompat:1.3.1 -> 1.6.1 (*)
+|    |    +--- androidx.fragment:fragment:1.5.1 -> 1.6.2 (*)
+|    |    +--- androidx.lifecycle:lifecycle-common:2.5.1 -> 2.6.2 (*)
+|    |    +--- androidx.lifecycle:lifecycle-viewmodel:2.5.1 -> 2.6.2 (*)
+|    |    +--- androidx.lifecycle:lifecycle-viewmodel-savedstate:2.5.1 -> 2.6.2 (*)
+|    |    \--- javax.inject:javax.inject:1
+|    +--- com.google.android.gms:play-services-auth:18.1.0 -> 20.7.0 (*)
+|    \--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.9.10 (*)
-\--- com.gravatar:gravatar:1.0.0
-     +--- com.squareup.retrofit2:retrofit:2.9.0
-     |    \--- com.squareup.okhttp3:okhttp:3.14.9 -> 4.12.0 (*)
-     +--- com.squareup.retrofit2:converter-gson:2.9.0
-     |    +--- com.squareup.retrofit2:retrofit:2.9.0 (*)
-     |    \--- com.google.code.gson:gson:2.8.5 -> 2.10.1
-     +--- org.jetbrains.kotlinx:kotlinx-coroutines-android:1.7.3 (*)
-     +--- com.squareup.okhttp3:okhttp:4.12.0 (*)
-     \--- org.jetbrains.kotlin:kotlin-stdlib:1.9.22 (*)
+\--- com.gravatar:gravatar:1.0.0 (*)

Please review and act accordingly

@wpmobilebot
Copy link
Contributor

Jetpack📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.
App NameJetpack Jetpack
FlavorJalapeno
Build TypeDebug
Versionpr20993-ed44c20
Commited44c20
Direct Downloadjetpack-prototype-build-pr20993-ed44c20.apk
Note: Google Login is not supported on these builds.

@wpmobilebot
Copy link
Contributor

WordPress📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.
App NameWordPress WordPress
FlavorJalapeno
Build TypeDebug
Versionpr20993-ed44c20
Commited44c20
Direct Downloadwordpress-prototype-build-pr20993-ed44c20.apk
Note: Google Login is not supported on these builds.

Copy link
Contributor

@staskus staskus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Works well now!

image

@staskus staskus merged commit 139ac49 into trunk Jun 17, 2024
21 of 23 checks passed
@staskus staskus deleted the update-login-flow-lib branch June 17, 2024 15:40
@staskus
Copy link
Contributor

staskus commented Jun 17, 2024

Thank you @NataliaDrause for the fix and contribution! It will be included in the 25.2 release of WordPress and Jetpack apps.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Login: in dark mode the carrot is not visible
3 participants