Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not replace the image drawable unless the bitmap is non-empty #5059

Merged
merged 3 commits into from
Jan 30, 2017
Merged

Do not replace the image drawable unless the bitmap is non-empty #5059

merged 3 commits into from
Jan 30, 2017

Conversation

0nko
Copy link
Contributor

@0nko 0nko commented Jan 25, 2017

Fixes #5045.

To test:

  1. Make sure Aztec is selected as the default editor in the settings
  2. Open a post with images
  3. Verify the image placeholder is shown and eventually is replaced by the actual image
  4. Go back to the post list, then go back to the same post
  5. Verify the image is loaded immediately from cache

@0nko 0nko mentioned this pull request Jan 27, 2017
Merged
@0nko 0nko mentioned this pull request Jan 30, 2017
Closed
5 tasks
@theck13 theck13 self-requested a review January 30, 2017 17:09
@theck13
Copy link
Contributor

theck13 commented Jan 30, 2017

I reverted the styling changes to be addressed a separate issue here.

theck13
theck13 approved these changes Jan 30, 2017
View reviewed changes
Copy link
Contributor

@theck13 theck13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@theck13 theck13 merged commit 8b2acbc into feature/aztec-integration Jan 30, 2017
@theck13 theck13 deleted the issue/5045-images-not-displayed branch January 30, 2017 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@theck13 theck13 theck13 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@0nko @theck13