Aztec - Switch the Title field EditText
#7021
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This doesn't fix wordpress-mobile/AztecEditor-Android#580 - removing the input filter on the title fixes the issue. |
maxme
reviewed
Dec 22, 2017
| @@ -129,7 +129,7 @@ | |||
| private boolean mEditorWasPaused = false; | |||
| private boolean mHideActionBarOnSoftKeyboardUp = false; | |||
|
|
|||
| private AztecText title; | |||
| private org.wordpress.android.editor.SourceViewEditText title; | |||
There was a problem hiding this comment.
Not a fan of using 2 different classes with the same name here, should we just rename the one in org.wordpress.android.editor to a more generic name since it's only a listening for IMEBack events?
|
Note: that I tried to replace the input filter with a text watcher doing the same thing to prevent newlines and it works fine with Swype. |
|
Pushed a commit in here, if you want to have a look: 189e467 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
titlefield in AztecEditorFragment is aAztecTextobject. Since there is no formatting, no advanced features on the title we can switch back to EditText.Don't think this will fix wordpress-mobile/AztecEditor-Android#580, but didn't try.