Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the list scrolling and swiping in Stats #8631

Merged
merged 5 commits into from Nov 22, 2018
Merged

Fix the list scrolling and swiping in Stats #8631

merged 5 commits into from Nov 22, 2018

Conversation

0nko
Copy link
Contributor

@0nko 0nko commented Nov 19, 2018

Fixes #8614.

To test:

Nested scrolling

  1. Go to Stats
  2. Wait for the stats to load
  3. Try swiping down over every block
  4. Notice the PTR view comes down only at the top of the list

PTR/View pager swiping

  1. Go to Stats
  2. Start swiping horizontally
  3. While partially between tabs, start swiping vertically
  4. Notice the PTR view doesn't come down

@wpmobilebot
Copy link
Contributor

1 Warning
⚠️ PR is not assigned to a milestone.

Generated by 🚫 Danger

@malinajirka
Copy link
Contributor

malinajirka commented Nov 22, 2018 •
edited

Thanks @0nko!

LGTM

I've noticed the Latest post summary and Comments flickers when PTR finishes. But it's not related to this PR.

@malinajirka malinajirka merged commit 4376298 into feature/stats_refresh_readonly Nov 22, 2018
@malinajirka malinajirka deleted the issue/8614-broken-scrolling branch November 22, 2018 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@malinajirka malinajirka Awaiting requested review from malinajirka

Assignees
No one assigned
Labels
Stats
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@0nko @wpmobilebot @malinajirka @irfano