Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix disappearing saved posts #8960

Merged
merged 4 commits into from Jan 21, 2019
Merged

Conversation

malinajirka
Copy link
Contributor

Fixes #8791

The issue is caused by a bug which has been in the app for ages, it just hadn't had any user-facing impact until we implemented Saved Posts.

We keep only 200 most recent posts for each tag in the cache. However, there is a bug in the SQL query so we are not removing just posts which don't fit in first 200, but also all posts which have different tag than the one currently selected.

To test

  1. Open Reader - followed sites tab
  2. Scroll down as far as you can (there is a limit)
  3. Save the last post in the list
  4. Go to Saved posts and notice the post is there
  5. Go to Discover tab
  6. Start following one of the sites
  7. Go back to Followed-sites tab
  8. Restart the app
  9. Go to Saved posts and notice the post is still there

Update release notes:

  • [ x ] If there are user facing changes, I have added an item to RELEASE-NOTES.txt.

cc @kwonye

@malinajirka malinajirka added this to the 11.7 milestone Jan 15, 2019
@theck13 theck13 self-assigned this Jan 15, 2019
Copy link
Contributor

@theck13 theck13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good to me. There is a conflict with the RELEASE-NOTES.txt file. Once that's resolved, it will be ready to merge.

@theck13
Copy link
Contributor

theck13 commented Jan 18, 2019

It looks like there is another conflict with the RELEASE-NOTES.txt file. Once that's resolved, it will be ready to merge.

@malinajirka
Copy link
Contributor Author

@theck13 It should be good to go;). Thanks

@theck13 theck13 merged commit d299713 into develop Jan 21, 2019
@theck13 theck13 deleted the issue/8791-disappearing-saved-posts branch January 21, 2019 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants