Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update gutenberg to v1.1.2 #9492

Merged
merged 2 commits into from
Mar 28, 2019
Merged

Update gutenberg to v1.1.2 #9492

merged 2 commits into from
Mar 28, 2019

Conversation

etoledom
Copy link
Contributor

This PR updates gutenberg to v1.1.2.

The change implemented can be seen here:
wordpress-mobile/gutenberg-mobile#790

To test:

  • These changes were already tested by @hypest here.
  • A smoke-test should be enough.

cc @jtreanor

@etoledom etoledom added the [Deprecated] gutenberg-mobile Deprecated label, use "Gutenberg" instead. label Mar 28, 2019
@etoledom etoledom added this to the 12.1 ❄️ milestone Mar 28, 2019
@etoledom etoledom self-assigned this Mar 28, 2019
hypest
hypest approved these changes Mar 28, 2019
View reviewed changes
Copy link
Contributor

@hypest hypest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Let's remember to update the gutenberg-mobile submodule hash to the merged (to master) one after the child PR gets merged.

@etoledom etoledom mentioned this pull request Mar 28, 2019
Merged
@etoledom etoledom merged commit ad627b4 into release/12.1 Mar 28, 2019
@etoledom etoledom deleted the issue/gutenberg-v1.1.2 branch March 28, 2019 12:53
@jtreanor jtreanor mentioned this pull request Apr 8, 2019
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hypest hypest hypest approved these changes

@daniloercoli daniloercoli Awaiting requested review from daniloercoli

Assignees

@etoledom etoledom

Labels
[Deprecated] gutenberg-mobile Deprecated label, use "Gutenberg" instead.
Projects
None yet
Milestone
12.1 ❄️
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@etoledom @hypest