Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #9826: make sure we Play Services are available before running the email hint picker. #9831

Merged
merged 1 commit into from
May 13, 2019
Merged

Fix #9826: make sure we Play Services are available before running the email hint picker. #9831

merged 1 commit into from
May 13, 2019

Conversation

maxme
Copy link
Contributor

@maxme maxme commented May 10, 2019

Fix #9826: make sure we Play Services are available before running the email hint picker.

The app won't crash, but there is some known limitations:

  • Users can't sign in/sign up with Google (but they get an error dialog).
  • Users won't receive push notification (and we don't tell them about it)

Note: I checked did a quick check of places where GoogleApiClient was used and I also ran the app and do a manual check of most features.

@maxme maxme added the Login label May 10, 2019
@maxme maxme requested a review from daniloercoli May 10, 2019 08:42
@maxme maxme added this to the 12.5 milestone May 10, 2019
daniloercoli
daniloercoli approved these changes May 10, 2019
View reviewed changes
Copy link
Contributor

@daniloercoli daniloercoli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on the S9 emulator and it fixed the crash.

Also smoke tested the app and didn't find any problem.

@daniloercoli daniloercoli merged commit 4145675 into develop May 13, 2019
@daniloercoli daniloercoli deleted the issue/9826-fix-for-9.0-devices-without-play-services-installed branch May 13, 2019 13:08
@daniloercoli daniloercoli mentioned this pull request Jul 16, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daniloercoli daniloercoli daniloercoli approved these changes

Assignees
No one assigned
Labels
Login
Projects
None yet
Milestone
12.5
Development

Successfully merging this pull request may close these issues.

Bring the app working again on devices without Google Services
2 participants
@maxme @daniloercoli