Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Fix upload notification not shown on retry #9956
This PR takes care of promoting the UploadService to the foreground (shows an upload in progress notification) when retrying upload.
I've removed this line
Update release notes:
mzorz left a comment
Thanks for diving into this @malinajirka
While reviewing this, I found another couple problems, which are not strictly related to this PR but may be quick to solve.
Problem A: with Posts with media (in particular, Aztec posts with media) - it is indeed a bit tricky, as also some things changed since the gradual introduction of Gutenberg that made things slip a bit.
(given both return
This in turn made the flag being passed to
This effectively means the Post wouldn't get registered for the upload, and media (if the Post contained failed media) wouldn't get retried.
The solution to this would be to just remove the
Re: the following:
I think the reason why it was there is because the retryUpload() method was mostly there to implement the "RETRY" button on a Notification (or on the Posts list itself). Apparently we haven't tested retrying more than one Post at once, hence the defect of assuming we could call
If you're ok with these changes, feel free to apply them - I prepared a patch where you can see them / you can also download the file and apply it to your branch if you think they're good (use
Following is a list of other two things that I found but don't have a suggestion for solving (we may open new issues)
Also, if you go back to the Posts list the Post will cease to exist, and so the Notification's RETRY button will do nothing (if you tap on the Notification, a "Post no longer exists" message will be shown).
Again, thanks for this PR, and let me know about the other issues (don't know if they're under someone's radar already)
Woow, thank you so much for the thorough review and for the great suggestions!
I've applied your patch. Thanks!!
This was recently fixed in #9962.
I've created a new issue - #9966.
Thanks @mzorz! I have just applied your patch and tested the app and it LGTM! It's ready for another round/merge.
Just a friendly reminder to please make sure to manually merge