Only overwrite Posts that don't have local changes #1064
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hen listening to completed FETCH_ACTION, only overwrite Posts that don't have local changes
1 task
oguzkocer
approved these changes
Jan 11, 2019
There was a problem hiding this comment.
Looks good @mzorz! I have left a couple nitpick comments, let me know what you think about them.
P.S: I know I was the one who brought up the changes in handleFetchSinglePostCompleted but I have to say, I am a little bit worried about the potential side effects of it. For one thing, each fetch request will take slightly longer and when a blog post list is visited for the very first time, there will be a lot of these, since we'll fetch each post one by one. Having said that, I can't think of an actual problem with this change, so I am hoping that it's fine :) I just wanted to add my thoughts here in case it proves useful later.
fluxc/src/main/java/org/wordpress/android/fluxc/store/PostStore.java
Outdated
Show resolved
Hide resolved
fluxc/src/main/java/org/wordpress/android/fluxc/store/PostStore.java
Outdated
Show resolved
Hide resolved
fluxc/src/main/java/org/wordpress/android/fluxc/store/PostStore.java
Outdated
Show resolved
Hide resolved
…e.java Co-Authored-By: mzorz <mariozorz@gmail.com>
…e.java Co-Authored-By: mzorz <mariozorz@gmail.com>
oguzkocer
approved these changes
Jan 14, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does two things:
2. also when listening to completedupdated as per convo in in Possible content loss when a draft is published from elsewhere WordPress-Android#5984 (comment)FETCH_ACTION, only overwrite Posts that don't have local changesOtherwise, local changes were lost for good.
Thanks @oguzkocer for pointing out where to make the changes!