Adds isMobileSegment property to VerticalSegmentModel #1089
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the FluxC side of wordpress-mobile/WordPress-Android#8999 by adding
isMobileSegment
property toVerticalSegmentModel
. The endpoint returns this property asmobile
, but I think this name makes it clear. I am open to suggestions for an even better name.I've also re-enabled the limit check for the verticals connected test. This basically tests that the
limit
parameter for the/verticals
endpoint is respected which has been recently fixed on the server-side.To test:
ReleaseStack_VerticalTest
ReleaseStack_VerticalTest.testFetchSegments
by putting a breakpoint inReleaseStack_VerticalTest.onSegmentsFetched
and observe that every segment except forOnline Store
has itsisMobileSegment
set totrue
.