Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quick Start for Existing Users V2 - Add existing site quick start tasks #2387

Merged
merged 2 commits into from
May 13, 2022

Conversation

ashiagr
Copy link
Contributor

@ashiagr ashiagr commented May 11, 2022

Parent wordpress-mobile/WordPress-Android#16350

This PR only adds tasks for the existing site quick start type.

PS: Currently only common tasks (CHECK_STATS, VIEW_SITE, FOLLOW_SITE) are enabled. The remaining tasks will be enabled when they're supported in the client app.

How to Test?

See wordpress-mobile/WordPress-Android#16530

New tasks are commented out. They'll be enabled once they're supported in the client app.
@ashiagr ashiagr self-assigned this May 11, 2022
Base automatically changed from issue/16350-refactor-for-different-qs-types-fluxc to trunk May 11, 2022 11:18
@ashiagr ashiagr requested a review from AjeshRPai May 12, 2022 10:01
@ashiagr ashiagr marked this pull request as ready for review May 12, 2022 10:01
@peril-wordpress-mobile
Copy link

You can trigger optional UI/connected tests for these changes by visiting CircleCI here.

Copy link
Contributor

@AjeshRPai AjeshRPai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have looked at the code changes and tested the Parent PR as per the instructions. Everything looks good to me. 👍 🙌

@ashiagr ashiagr merged commit f4ed96f into trunk May 13, 2022
@ashiagr ashiagr deleted the issue/16350-add-tasks-for-existing-site-qs-type-fluxc branch May 13, 2022 07:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants