-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove Jetifier #56
Remove Jetifier #56
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👋 @0nko !
This is great, I just reviewed and tested the PR, everything looks good to me. I also double-checked with Bye bye Jetifier
and it was successful, thank you! 🚀 🎉 🍾
To test:
Verify the library and the sample app can be built and that the GIF search works when running the sample app (you'll need an API key)
Btw, I tested the sample app, with an without an API key, and to my suprise both builds was working when I tried to search for a GIF even when having <ADD API KEY HERE>
as the TENOR_API_KEY
key... 🤷 😅 🤔
👋 @0nko ! It is still a 👍 🟢 from my side, maybe @malinajirka wants to take a look as well, so I am letting you two merge this PR. PS: About the Lint issue that you fixed by updating the outdated dependencies, in my other PR here, I actually didn't do the update, but instead suppressed the |
Thanks, @ParaskP7!
Huh, that's weird 😆
Yeah.. But here it's not as much of a problem since it's much simpler to check if any of the flows might get broken by an update. So I'd say let's keep the newer versions. But I'll think about suppressing the errors next time. |
👋 @0nko !
😅
True! 👍 PS: Let me merge this now in order to progress with this |
This PR replaces the Tenor library dependency reference with a jetified AAR version.
To test:
Verify the library and the sample app can be built and that the GIF search works when running the sample app (you'll need an API key)