Hide the upgrade button it no upgradeURL present

wordpress-mobile · Jun 10, 2024 · acb42db · acb42db
1 parent 743c0ba
commit acb42db
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 12 deletions.
diff --git a/WordPress/Classes/ViewRelated/Voice/VoiceToContentView.swift b/WordPress/Classes/ViewRelated/Voice/VoiceToContentView.swift
@@ -96,10 +96,12 @@ private struct VoiceToContentWelcomeView: View {
         VStack(spacing: 4) {
             Text(Strings.notEnoughRequests)
                 .multilineTextAlignment(.center)
-            Button(action: viewModel.buttonUpgradeTapped) {
-                HStack {
-                    Text(Strings.upgrade)
-                    Image("icon-post-actionbar-view")
+            if let upgradeURL = viewModel.upgradeURL {
+                Button(action: { viewModel.buttonUpgradeTapped(withUpgradeURL: upgradeURL) }) {
+                    HStack {
+                        Text(Strings.upgrade)
+                        Image("icon-post-actionbar-view")
+                    }
                 }
             }
         }.frame(maxWidth: 320)

diff --git a/WordPress/Classes/ViewRelated/Voice/VoiceToContentViewModel.swift b/WordPress/Classes/ViewRelated/Voice/VoiceToContentViewModel.swift
@@ -24,6 +24,9 @@ final class VoiceToContentViewModel: NSObject, ObservableObject, AVAudioRecorder
         return isEligible
     }
 
+    var upgradeURL: URL? {
+        featureInfo?.upgradeURL.flatMap(URL.init)
+    }
     private var featureInfo: JetpackAssistantFeatureDetails?
     private var audioSession: AVAudioSession?
     private var audioRecorder: AVAudioRecorder?
@@ -112,15 +115,8 @@ final class VoiceToContentViewModel: NSObject, ObservableObject, AVAudioRecorder
         }
     }
 
-    func buttonUpgradeTapped() {
+    func buttonUpgradeTapped(withUpgradeURL upgradeURL: URL) {
         WPAnalytics.track(.voiceToContentButtonUpgradeTapped)
-
-        guard let featureInfo else {
-            return wpAssertionFailure("feature info missing")
-        }
-        guard let upgradeURL = featureInfo.upgradeURL.flatMap(URL.init) else {
-            return wpAssertionFailure("invalid or missing upgrade URL")
-        }
         UIApplication.shared.open(upgradeURL)
     }