Skip to content

Commit

Permalink
Remove .freeze from bundle ids array for match
Browse files Browse the repository at this point in the history
  • Loading branch information
mokagio committed Mar 25, 2022
1 parent d9119df commit cd585ae
Showing 1 changed file with 13 additions and 1 deletion.
14 changes: 13 additions & 1 deletion fastlane/Fastfile
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,19 @@ EXTENSIONS_BUNDLE_IDENTIFIERS = %w[
WordPressThisWeekWidget
WordPressIntents
].map { |suffix| "#{APP_STORE_VERSION_BUNDLE_IDENTIFIER}.#{suffix}" }
ALL_BUNDLE_IDENTIFIERS = [APP_STORE_VERSION_BUNDLE_IDENTIFIER, *EXTENSIONS_BUNDLE_IDENTIFIERS].freeze
# rubocop:disable Style/MutableConstant
#
# Fastlane `match` manipulates the array of bundle identifiers it's given in a
# way that expects it to be mutable. We cannot call `.freeze`, or `match` will
# fail.
#
# See:
#
# - https://github.com/fastlane/fastlane/issues/11324
# - https://github.com/fastlane/fastlane/blob/b817148d4967ab6e38b8f1a8b81d1b3e60d6e645/match/lib/match/runner.rb#L84-L86
# - https://buildkite.com/automattic/wordpress-ios/builds/6240#ad789b9f-b744-4867-8d58-95921c58a3cf/2491-2756
ALL_BUNDLE_IDENTIFIERS = [APP_STORE_VERSION_BUNDLE_IDENTIFIER, *EXTENSIONS_BUNDLE_IDENTIFIERS]
# rubocop:enable Style/MutableConstant
JETPACK_APP_IDENTIFIER = 'com.automattic.jetpack'

# Environment Variables — used by lanes but also potentially actions
Expand Down

3 comments on commit cd585ae

@AliSoftware
Copy link
Contributor

@AliSoftware AliSoftware commented on cd585ae Mar 25, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Attempted to fix this issue at its core in fastlane here: fastlane/fastlane#20125

Hopefully if/once that fix lands in fastlane and ships, we will be able to revert this change you made here 🤞

@mokagio
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I always felt it would have been a manageable thing to fix but never made the time for it. I'm out of Automattic's kudos for the month, but kudos to you! 😅 👏

@mokagio
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

By the way, your PR landed already 🎉 I'll keep an eye out for new Fastlane releases and update accordingly once shipped 😄

Please sign in to comment.