Replace if let strongSelf = self and if let self = self checks in closures with modern if let self

[mokagio]

There's nothing wrong with using if let strongSelf = self or guard let strongSelf = self. However, strongSelf makes the code a bit more cumbersome to read.

strongSelf or any other name different from self used to be required when we couldn't use that keyword in an assignment within a closure, but we now can and do so in various places, e.g.

WordPress-iOS/WordPress/Classes/ViewRelated/Stats/Insights/SiteStatsInsightsTableViewController.swift

Lines 512 to 514 in 939521f

	guard let self = self else {
	return
	}

We should remove the leftover instances of this old pattern and keep the codebase homogeneous.

Update, we can actually use an even better syntax:

if let self {
  ...
}

I renamed the issue accordingly to include acting on both strongSelf = self and self = self.

[twstokes]

👋 @mokagio - how do we feel about SE-0345 shorthand in these cases? We may need to address it in the style guide either way.

[mokagio]

I didn't know about SE-0345 or about the style guide.

Love them both. Thanks!

Yes. We should definitely adopt the new syntax because it's more compact and clear, as well as updating the style guide to mention it.

[mokagio]

I just noticed that a recent SwiftLint version add a rule for this: realm/SwiftLint#4202 🦾