New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Some uploaded images have device path for src, not the image URL on the blog. #5923
Comments
This one is causing me huge issues with our multisite install and iOS app. Any updates? |
@mattdoble89, its been a tricky one to nail down. Have you seen any error message while uploading images? If so, can you describe them in detail? Also, in the app you can look under Me > Help & Settings and enable Extra Debug. Then reproduce the issue. Then look under Me > Help & Settings > Activity Logs to see if the Current Log has captured any errors. You can share the log here if you like. We'd be keen on trying to troubleshoot this one directly if you'd be willing to share some credentials for a test account with an editor role. If so, you could email them to "mobile at automattic dot com" (note the three 't's in automattic). |
OK, thank you for looking. It is causing me major pain. It is intermittent for us, it works one minute and not the next, when it doesn't work it simply loads the image in greyscale, and never goes full colour. I have just emailed you a set of details. Hopefully this will prove useful. I will lookup errors logs, although sure you can reproduce these quickly. |
Thanks Matt. We've received the email. We really appreciate the chance to work on this. @SergioEstevao or I will follow up here with what we find. |
OK, cheers guys. Hopefully this helps, any additional info let me know. Hope you have been able to replicate the error?? The site itself is all behind SimpleSAML authentication, so you will need to login even to view site, but the issue was happening before this was installed. |
So far no, but I'm still trying different things hoping to find the right trigger.
That's good to know. I noticed I'm prompted to relogin after 10 minutes of inactivity in the admin and I wondered if it could be related. I'm guessing that is a feature of SimpleSAML? |
Mm, OK, we normally get it every five or so uploads on iOS. Try with different images, we have always replicated very quickly. I had not noticed that, I will look into it. |
@mattdoble89 a couple of quick questions
When this happens, is the image overlaid with an error message and a "Retry" button, or is it just the image in a grayscale/disabled state? Also, does this happen while the app is active and in the foreground or when a user has pressed the home button to background the app? |
More questions (sorry)
Any more details on this? Is it one image per post, or multiple images for a single post? Also, it would be helpful to know if when it happens the image has actually uploaded successfully to the blog. |
The image is greyscale, the loading bad along the top of the image makes it to 100% but the spinning wheel stays on the app forever, never completing or erroring. This happens when the app is in the foreground and active. The user can press back, and the post appears in the post list and looks to have posted, however the image is not shown in the preview list of all posts. We ask users to upload one image per post, it may also happen with more than one but definitely happens with one. I will login to the server now and see if I can find an image I know it happened with earlier. |
Good info. Thank you! |
Yes, the images are indeed uploaded to the uploads folder, and in a range of dimensions. The URL to the image is however: |
Hope this helps! |
Finally reproduced this on an iPhone 5, and an iPhone 6s. My steps to reproduce:
In this particular circumstance timing appears to be a factor and it seems like a bit of a race condition. Perhaps due to saving on a derived context and updating the main context asyncronously, but I haven't dug into it that far yet. This doesn't seem like a perfect fit for the never ending spinner that Matt described. However, it looks like that could potentially be attributed to a networking issue. Notice that the failure block in In any event, it looks like we have two potential angles of attack:
@SergioEstevao thoughts? |
@aerych two notes:
|
Ah. I think I misunderstood what |
@aerych investigated a bit more and it looks option 1) the race condition is happening. If you are very quick to press post or update after the image upload is done you get that inconsistent state. |
@mattdoble89 would you be game to test our fix for the race condition and see if it also takes care of the issue you're seeing? I'm hopeful but not 100% sure its the same bug. We can email you a link to a patched version of the app to test with. Edit: Link sent just in case :) |
Yes please, very keen to test. Also not sure it is the same, ours is unrelated to the button press and happens regardless, but I am hopeful! I dont seem to have received link though? |
@mattdoble89 I forwarded another copy. Its coming from my automattic email address and is titled "Link to test a patched version of WordPress for iOS". |
Thanks for the email, but I am now getting "Error occurred during Publishing" message, and the post remains local only. |
Also, if I go in and edit a previous post, the images are removed upon update. |
Do you get this error when uploading the image? or after you press post? On Wed, Oct 5, 2016 at 8:55 AM, mattdoble89 notifications@github.com
|
When I press post, it goes back to the post list as if working, but the post is in Local state, and after five seconds or so the error message appears. |
Are there any further steps we can take? |
I had a look, an it looks that the fix done, sometimes cleans all the On Wed, Oct 5, 2016 at 8:45 PM, mattdoble89 notifications@github.com
|
OK, Is there a fix you are able to put in place for this? Thanks again for your time! Let me know if we can help. |
@SergioEstevao I did some digging into this and I think I've found the issue. I wanted to comment here so @mattdoble89 aware of our progress but I'll share the details on the PR. |
Excited to hear any progress. Can we test? If the bug is found/fixed, how is the update rolled out? |
For sure! Once the patch is updated I'll send you a new link to install a test build of the app.
Assuming we've fixed the bug it should be included in version 6.6 of the app, and available in the app store in a few weeks. |
Brilliant, look forward to hearing something! |
@mattdoble89, sorry to keep you waiting. Our patch has been applied to the app and I'm emailing an updated link to install a beta. Hoping it resolves the issue! |
Brilliant, be good to give it a try once you have a link! Any ideas when the update will be applied to app store? |
@mattdoble89 @aerych Was this one resolved? |
@astralbodies No new reports afaik. Let's assume resolved and reopen if needed. |
Reported in the forums:
Opening this issue to track.
The text was updated successfully, but these errors were encountered: