Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cant login to self hosted sites #11639

Merged
merged 4 commits into from May 6, 2019

Conversation

diegoreymendez
Copy link
Contributor

Description:

Fixes a bug that was preventing users from loging in with their site address if they didn't add the https:// or http:// prefixes.

This issue is only present in 12.4 (develop currently) and never went live. It's important that we merge this before the internal release of 12.4 tomorrow.

Fixes #11617

To test:

Log into a site using the site's address.

  • If there are user facing changes, I have added an item to RELEASE-NOTES.txt.

@diegoreymendez
Copy link
Contributor Author

Fyi @elibud and @rachelmcr

Copy link
Contributor

@jkmassel jkmassel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is ok as it just references the updated changes in WPAuthenticator

@jkmassel
Copy link
Contributor

jkmassel commented May 6, 2019

Merging to get this into 12.4

@jkmassel jkmassel merged commit 8d8e741 into develop May 6, 2019
@jkmassel jkmassel deleted the issue/11617-cant-login-to-self-hosted-sites branch May 6, 2019 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Login: Can't log in to self-hosted sites
4 participants