New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement Stats Refresh analytics events #11757
Conversation
Once the backing PR in |
Thanks for the details in the description @stevebaranski . That's very helpful! |
Hey Steve.
Are you sure dev tracks go there? I didn't see any. I used the Event Name I do see them as |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Thanks for the review, @ScoutHarris!
Yes, though there is generally some latency. I took the liberty to express the same query for your username, and found some now. Hopefully that provides you some assurance that things are working as expected. In any case, I'll merge this once I take care of versioning |
Ah! Apparently I wasn't patient enough. Thanks! |
Summary
Fixes #11730.
To test:
WPAnalyticsTrackerAutomatticTracksTests
.It's probably easiest to validate events in one of the following two ways:
Update release notes:
RELEASE-NOTES.txt
.Discussion
Absent explicit requirements, it took some time & energy to distill the specific changes that needed to be made. For this reason, I've chosen to chronicle my approach below. Please advise if I missed something!
WPAnalytics.h
(seeWordPressShared
).WPAnalytics.m
prescribeseventName
properties that match the aforementioned Android implementation."Legacy" Events
WPAnalyticsStatStatsInsightsAccessed
WPAnalyticsStatStatsPeriodDaysAccessed
WPAnalyticsStatStatsPeriodWeeksAccessed
WPAnalyticsStatStatsPeriodMonthsAccessed
WPAnalyticsStatStatsPeriodYearsAccessed
WPAnalyticsStatStatsScrolledToBottom
WPAnalyticsStatStatsSinglePostAccessed
Latest Post Summary Events
WPAnalyticsStatStatsItemTappedLatestPostSummaryNewPost
WPAnalyticsStatStatsItemTappedLatestPostSummaryPost
WPAnalyticsStatStatsItemTappedLatestPostSummarySharePost
WPAnalyticsStatStatsItemTappedLatestPostSummaryViewPostDetails
View More Events
WPAnalyticsStatStatsViewAllAccessed
(legacy event)WPAnalyticsStatStatsViewMoreTappedAuthors
WPAnalyticsStatStatsViewMoreTappedClicks
WPAnalyticsStatStatsViewMoreTappedComments
WPAnalyticsStatStatsViewMoreTappedCountries
WPAnalyticsStatStatsViewMoreTappedFollowers
WPAnalyticsStatStatsViewMoreTappedLatestPostSummary
WPAnalyticsStatStatsViewMoreTappedPostsAndPages
WPAnalyticsStatStatsViewMoreTappedPublicize
WPAnalyticsStatStatsViewMoreTappedReferrers
WPAnalyticsStatStatsViewMoreTappedSearchTerms
WPAnalyticsStatStatsViewMoreTappedTagsAndCategories
WPAnalyticsStatStatsViewMoreTappedVideoPlays
Additional Row Selection Events
WPAnalyticsStatStatsItemTappedAuthors
WPAnalyticsStatStatsItemTappedClicks
WPAnalyticsStatStatsItemTappedPostsAndPages
WPAnalyticsStatStatsItemTappedSearchTerms
WPAnalyticsStatStatsItemTappedSummaryPost
WPAnalyticsStatStatsItemTappedTagsAndCategories
WPAnalyticsStatStatsItemTappedVideoPlays
The following events required no changes:
WPAnalyticsStatStatsAccessed
, still implemented inBlogDetailsViewController
.WPAnalyticsStatStatsOverviewBarChartTapped
, implemented previously.The following event(s) appear to be obsolete, and can be removed via #10975:
WPAnalyticsStatStatsTappedBarChart