Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added "Create Page" button to no results view when offline #12308

Merged
merged 1 commit into from Aug 16, 2019

Conversation

yaelirub
Copy link
Contributor

@yaelirub yaelirub commented Aug 14, 2019

Fixes #12049

To test:

  1. Be offline
  2. Go to Pages
  3. See the no results view with "Create Page" button
  4. tap create page
  5. Enter title / Content
  6. Exit the editor with "Save Draft"
  7. See that draft page was created and a notice that it wasn't uploaded

IMG_4709

Update release notes:

  • If there are user facing changes, I have added an item to RELEASE-NOTES.txt.

@rachelmcr
Copy link
Member

@yaelirub I took a look at the failing UI test and confirmed the failure was unrelated to your change. Running the tests locally and re-running them on CI both passed. I'll take a look at that flakiness and see if I can fix it in a followup PR.

Copy link
Contributor

@diegoreymendez diegoreymendez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as described!

@yaelirub yaelirub merged commit c4a0021 into develop Aug 16, 2019
Offline Support: Posting [iOS] automation moved this from In Review to Done (PRs) Aug 16, 2019
@yaelirub yaelirub deleted the 12049_create_page_offline branch August 22, 2019 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

"Create Page" button should be shown when offline too.
3 participants