[Dark Mode] Fix text color in Aztec - HTML text view #12462
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielebogo
requested review from
frosty,
etoledom and
mattmiklic
and removed request for
frosty
mattmiklic
approved these changes
Sep 4, 2019
etoledom
approved these changes
Sep 4, 2019
There was a problem hiding this comment.
Works great! 🎉
Tested via wordpress-mobile/AztecEditor-iOS#1209
Podfile.lock
Outdated
| @@ -3,7 +3,7 @@ PODS: | |||
| - Alamofire (4.7.3) | |||
| - AlamofireNetworkActivityIndicator (2.3.0): | |||
| - Alamofire (~> 4.7) | |||
| - Automattic-Tracks-iOS (0.4.0): | |||
| - Automattic-Tracks-iOS (0.4.1): | |||
There was a problem hiding this comment.
I don't understand these changes on Podfile.lock 🤔
Maybe they are outdated on the release branch?
There was a problem hiding this comment.
Podfile.lock should be ok now!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs. #12320
This PR set the color to the HTML textView in the Aztec editor.
I'll update the Podfile as soon Aztec #1209 will be merged
Adding also @mattmiklic to set the right colors used for the comments and the tags.
To test:
• Run the branch with Xcode 11 and iOS 13
• Edit a post and switch between visual and HTML mode
• Check the html text color is not black in Dark Mode
• Run it on iOS 12 to check everything works fine
Update release notes:
RELEASE-NOTES.txtif necessary.