New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add react-native-linear-gradient lib #13060
Conversation
You can trigger an installable build for these changes by visiting CircleCI here. |
Generated by 🚫 dangerJS |
0168526
to
3f17eaf
Compare
@lukewalczak this is coming along very nicely. Here are a few notes I made as feedback during testing (on WPiOS via the build mentioned above):
Let me know if you have any questions! |
Thanks for a feedback @iamthomasbishop!
Ok, I'll adjust it according to your suggestion.
Actually, horizontal paddings have 16px, however paddings - one character | paddings - more characters |
Will change it!
Working over that, however, as I mentioned on slack we will not face these issues once we choose an approach where only when user tap directly the Let me know what do you think! |
Ahhh, that makes sense (that extra spacing issue has been creeping up in a bunch of places 😞 ). I think we're solving it elsewhere, so no need to change here. Your notes regarding tapping directly on RichText vs the block boundary makes sense. Although I think most users will expect that an initial on the button itself will focus it, I think once they're familiar of the concept of blocks and can see where the boundaries are, it'll be more obvious. I'll keep an eye on this during upcoming usability tests. |
eed2846
to
cc1b30d
Compare
LGTM! Tested with the steps I mentioned in the gutenberg PR. But, since the release branch is cut, we should merge into (Another option is waiting until the release branch is merged into develop again which will happen next Monday) |
5fbc632
to
644ad0e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Fixes #
Ref to gb-mobile: wordpress-mobile/gutenberg-mobile#1616
Ref to gutenberg: WordPress/gutenberg#18823
This PR introduces 1st iteration of mobile
Button
block component.To achieve gradient background color on mobile
react-native-linear-gradient
comes in handy.The first iteration includes:
Button
with:RichText
✅To test:
-> Gradient
Screenshot / gifs:
IOS
PR submission checklist:
I have considered adding unit tests where possible.
I have considered if this change warrants user-facing release notes and have added them to
RELEASE-NOTES.txt
if necessary.