Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Gutenberg] Update to v1.21.0 #13250

Merged
merged 19 commits into from Jan 24, 2020
Merged

Conversation

etoledom
Copy link
Contributor

@etoledom etoledom commented Jan 20, 2020

Gutenberg-mobile PR: wordpress-mobile/gutenberg-mobile#1788

PR submission checklist:

  • I have considered adding unit tests where possible.

  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@etoledom etoledom added the Gutenberg Editing and display of Gutenberg blocks. label Jan 20, 2020
@etoledom etoledom added this to the 14.1 milestone Jan 20, 2020
@etoledom etoledom self-assigned this Jan 20, 2020
@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Jan 20, 2020

You can trigger an installable build for these changes by visiting CircleCI here.

@etoledom etoledom marked this pull request as ready for review January 21, 2020 16:38
Copy link
Contributor

@maxme maxme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I checked the margin and I smoke tested the editor. Everything look fine.

I don't see any changes to ChangeLog (should we mention the updated margins and crash fix?).

Same comment I had in wpandroid about the shortcode, I think we should mention the new shortcode block, even if it was released in 14.0.

@SergioEstevao were you trying to fix the UI tests?

@maxme
Copy link
Contributor

maxme commented Jan 23, 2020

I updated the release notes in cfdcc87

Copy link
Contributor

@SergioEstevao SergioEstevao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working well for me, just needs the merge conflict to be sorted out and :shipit: !

@etoledom
Copy link
Contributor Author

Thank you @SergioEstevao for fixing the UI Tests issue! And both of you for the review 🙏

Copy link
Contributor

@maxme maxme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@maxme maxme merged commit f688227 into develop Jan 24, 2020
@maxme maxme deleted the gutenberg/integrate_release_1.21.0 branch January 24, 2020 07:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Gutenberg Editing and display of Gutenberg blocks.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants