Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable editing GIFs in the classic editor. #14279

Closed
wants to merge 1 commit into from

Conversation

ScoutHarris
Copy link
Contributor

Ref ##13803 (comment)

This removes the ability to edit a GIF when added to a post/page via the classic editor. The block editor will be updated with WordPress/gutenberg#23036.

To test:

  • Create a new post or page.
  • Switch to the classic editor.
  • Insert media, and select Free GIF Library.
  • Select a GIF. Wait for it to finish loading.
  • Tap on the GIF.
  • Verify Edit does not appear in the options list.
GIF options Image options
gif_options image_options

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@ScoutHarris ScoutHarris added [Type] Enhancement Media Editing Allowing our users to edit media. labels Jun 9, 2020
@ScoutHarris ScoutHarris added this to the 15.1 milestone Jun 9, 2020
@ScoutHarris ScoutHarris requested a review from Gio2018 June 9, 2020 18:24
@ScoutHarris ScoutHarris self-assigned this Jun 9, 2020
@peril-wordpress-mobile
Copy link

You can trigger an installable build for these changes by visiting CircleCI here.

@peril-wordpress-mobile
Copy link

You can trigger optional UI/connected tests for these changes by visiting CircleCI here.

@ScoutHarris
Copy link
Contributor Author

@SergioEstevao requested we just show an alert in both editors notifying the user that the animations will be lost upon editing, instead of preventing editing altogether.

@ScoutHarris ScoutHarris closed this Jun 9, 2020
@ScoutHarris ScoutHarris deleted the fix/13803-disable_gif_editing branch June 9, 2020 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Media Editing Allowing our users to edit media. Tenor [Type] Enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant