AB testing: schedule a refresh based on TTL #15226
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You can trigger an installable build for these changes by visiting CircleCI here. |
|
You can trigger optional UI/connected tests for these changes by visiting CircleCI here. |
This will make easier to extrat it to a library
…, decoupling from WPiOS
emilylaguna
suggested changes
Nov 5, 2020
| return | ||
| } | ||
|
|
||
| self.scheduleTimer = Timer.scheduledTimer(withTimeInterval: self.ttl, repeats: true) { [weak self] timer in |
There was a problem hiding this comment.
I've had a lot of issues with timers in the past, I think you should invalidate and reset when the app goes to the background or comes to the foreground.
There was a problem hiding this comment.
Good point!
Changed in 629db96
emilylaguna
approved these changes
Nov 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of wordpress-mobile/WordPress-iOS-Shared#278
This PR:
tllthat the ExPlat response returnsURLSessioninstead ofWordPressComRestApiThe latter two will help to extract it to https://github.com/Automattic/Automattic-Tracks-iOS
To test
Again, rely on the code/tests. :)
PR submission checklist:
RELEASE-NOTES.txtif necessary.