-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reader: remove unused files #15414
Reader: remove unused files #15414
Conversation
You can trigger an installable build for these changes by visiting CircleCI here. |
Generated by 🚫 dangerJS |
You can trigger optional UI/connected tests for these changes by visiting CircleCI here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Smoke-tested likes, commenting, saved posts, reblogging, navigating deeper into the levels of Reader from different origins, followed / unfollowed sites and checked out a few action sheet items. LGTM!
Thanks @mindgraffiti ! |
ReaderSavedPostCellActionsDelegate was deleted in #15414, but turns out we need it.
ReaderSavedPostCellActionsDelegate was deleted in #15414, but turns out we need it.
Fixes #n/a
Ref: #15382
This removes all (as far as I can tell) unused Reader files. Specifically:
There is one more final cleanup step to do in a future PR, and that is to address the
TODO: - READERNAV
s.To test:
Note: there is an existing issue with unsaving posts from the Saved filter.
PR submission checklist:
RELEASE-NOTES.txt
if necessary.