Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reader: remove unused files #15414

Merged
merged 9 commits into from
Dec 1, 2020
Merged

Conversation

ScoutHarris
Copy link
Contributor

@ScoutHarris ScoutHarris commented Nov 30, 2020

Fixes #n/a
Ref: #15382

This removes all (as far as I can tell) unused Reader files. Specifically:

  • ReaderSavedPostsViewController
  • ReaderSavedPostCellActions
  • ReaderMenuViewController
  • ReaderFollowedSitesStreamHeader
  • ReaderMenuViewModel and related classes.
    • DiscoverMenuItemCreator
    • FollowingMenuItemCreator
    • LikedMenuItemCreator
    • OtherMenuItemCreator
    • ReaderMenuItemCreator
    • SavedForLaterMenuItemCreator
    • SearchMenuItemCreator

There is one more final cleanup step to do in a future PR, and that is to address the TODO: - READERNAVs.

To test:

  • There should be no functional changes, so just smoke test the Reader and all the filters to ensure they behave as expected.
  • Verify the unit and UI tests pass on this PR.

Note: there is an existing issue with unsaving posts from the Saved filter.

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@ScoutHarris ScoutHarris self-assigned this Nov 30, 2020
@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Nov 30, 2020

You can trigger an installable build for these changes by visiting CircleCI here.

@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Nov 30, 2020

Warnings
⚠️ PR has more than 500 lines of code changing. Consider splitting into smaller PRs if possible.

Generated by 🚫 dangerJS

@ScoutHarris ScoutHarris added this to the 16.4 milestone Nov 30, 2020
@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Nov 30, 2020

You can trigger optional UI/connected tests for these changes by visiting CircleCI here.

@ScoutHarris ScoutHarris marked this pull request as ready for review November 30, 2020 23:37
Copy link
Contributor

@mindgraffiti mindgraffiti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Smoke-tested likes, commenting, saved posts, reblogging, navigating deeper into the levels of Reader from different origins, followed / unfollowed sites and checked out a few action sheet items. LGTM!

@ScoutHarris
Copy link
Contributor Author

Thanks @mindgraffiti !

@ScoutHarris ScoutHarris merged commit 9f8fdce into develop Dec 1, 2020
@ScoutHarris ScoutHarris deleted the issues/remove_unused_reader_files branch December 1, 2020 18:45
momo-ozawa added a commit that referenced this pull request Dec 15, 2020
ReaderSavedPostCellActionsDelegate was deleted in #15414, but turns out we need it.
@momo-ozawa momo-ozawa mentioned this pull request Dec 15, 2020
3 tasks
momo-ozawa added a commit that referenced this pull request Dec 16, 2020
ReaderSavedPostCellActionsDelegate was deleted in #15414, but turns out we need it.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants