Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply Default Values to the CoreData items added in 117 #16170

Merged
merged 1 commit into from Mar 29, 2021

Conversation

chipsnyder
Copy link
Contributor

@chipsnyder chipsnyder commented Mar 26, 2021

Fixes a migration issue that was a result of changes made when adding some values to the 117 Data Model.

To test:

  1. Install a previous build such as one from trunk
  2. Navigate to the page creation screen where you can pick starter content
    • This will populate entities that will be migrated in the next step
  3. Install a build from this branch
  4. Expect the Migration to be successful
  5. Navigate to the page creation screen where you can pick starter content
  6. Expect to not have any issues loading that page

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@chipsnyder chipsnyder added [Type] Bug Core Data Issues related to Core Data labels Mar 26, 2021
@chipsnyder chipsnyder added this to the 17.0 ❄️ milestone Mar 26, 2021
@chipsnyder chipsnyder requested a review from mkevins March 26, 2021 14:24
@peril-wordpress-mobile
Copy link

You can trigger an installable build for these changes by visiting CircleCI here.

@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Mar 26, 2021

Warnings
⚠️ Core Data: Do not edit an existing Core Data model in a release branch unless it hasn't been released to testers yet. Instead create a new model version and merge back to develop soon.
⚠️ PR has more than 500 lines of code changing. Consider splitting into smaller PRs if possible.

Generated by 🚫 dangerJS

@peril-wordpress-mobile
Copy link

You can trigger optional UI/connected tests for these changes by visiting CircleCI here.

Copy link
Contributor

@mkevins mkevins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested this by the steps described, and it's working without a migration failure now. Thank you for tackling this with the version bump Chip!

@chipsnyder chipsnyder merged commit 576f9c6 into release/17.0 Mar 29, 2021
@chipsnyder chipsnyder deleted the fix/coreData117MigrationIssue branch March 29, 2021 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Core Data Issues related to Core Data [Type] Bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants