Handle stories media uploading post-publish

[bjtitus]

Fixes #16054

Related PRs

• Kanvas

Summary

Media Uploading

Changes the media upload process for stories to add media to the post through the existing addMedia method. Upon saving (and publishing) the post, the media references are updated if upload has completed or observed and then updated once complete.

This prevents the case where media may not be uploaded by the time the Publish button was tapped, leading to a case where post status wasn't changed (due to an issue with media observers clashing).

Kanvas Loading States

The Kanvas updates improve the loading state handling for multiple export. The loading indicator should appear during export and hide once export is complete -- about the same time the Prepublishing Sheet is shown.

Upload.from.GitHub.for.iOS.MOV

Testing

Note: There is a known issue with text positioning which will be fixed separately.

• Create a new Story
• Add multiple media items
• Tap the Arrow button in the upper right
• Quickly tap the Publish button without adding a title
• You should see the media uploading in the Drafts list and it should move to Published when complete

Regression Notes

1. Potential unintended areas of impact

• Any post publishing (both stories and blog posts or pages)
• Any post editing (both stories and blog posts or pages)

2. What I did to test those areas of impact (or what existing automated tests I relied on)

• Tested publishing a new story and editing an existing story
• Tested publishing a new post and editing an existing post (with media)
• Tested publishing a new page and editing an existing page

3. What automated tests I added (or what prevented me from doing so)

I'm not sure where to add automated tests for this.

PR submission checklist:

• I have completed the Regression Notes.
• I have considered adding unit tests for my changes.
• I have considered adding accessibility improvements for my changes.
• I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

[peril-wordpress-mobile]

You can trigger an installable build for these changes by visiting CircleCI here.

[peril-wordpress-mobile]

You can trigger optional UI/connected tests for these changes by visiting CircleCI here.

[aerych]

Hola @bjtitus 👋
Tested as described. I was able to select multiple media files, publish without a title, and see the uploading media status while viewing the drafts list.
There seems to some lag in several places: between selecting the media and rendering in the story editor and between responding to a tap of the arrow button and showing the spinner, but I don't see how that would be related to these changes.
from me.