Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix stories 9:16 export #16451

Closed
wants to merge 0 commits into from
Closed

Fix stories 9:16 export #16451

wants to merge 0 commits into from

Conversation

bjtitus
Copy link
Contributor

@bjtitus bjtitus commented May 7, 2021

Fixes tumblr/kanvas-ios#62

Testing

  • Create a Story post
  • Add landscape and portrait media
  • Add text to the media
  • Ensure that the media posted uploaded to the site is roughly 9:16. (about 0.5625 when dividing the width by the height)
  • Ensure text is positioned as expected

Regression Notes

  1. Potential unintended areas of impact

Anything related to Story media export.

  1. What I did to test those areas of impact (or what existing automated tests I relied on)

Tested posting stories with a variety of media sizes and types.

  1. What automated tests I added (or what prevented me from doing so)

Unfortunately, the OpenGL rendering will not work in the simulator so we cannot test this.

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding unit tests for my changes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@bjtitus bjtitus added this to the 17.3 ❄️ milestone May 7, 2021
@bjtitus bjtitus requested a review from aerych May 7, 2021 20:13
@bjtitus bjtitus self-assigned this May 7, 2021
@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented May 7, 2021

You can trigger optional UI/connected tests for these changes by visiting CircleCI here.

@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented May 7, 2021

You can trigger an installable build for these changes by visiting CircleCI here.

@bjtitus bjtitus removed the request for review from aerych May 7, 2021 20:21
@bjtitus bjtitus marked this pull request as draft May 7, 2021 20:21
@bjtitus bjtitus closed this May 11, 2021
@bjtitus bjtitus deleted the fix/stories-9-16-export branch May 11, 2021 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant