About screen: Disable haptics when app logos cell isn't visible

[frosty]

This PR can be used to test the associated AutomatticAbout-Swift PR: Automattic/AutomatticAbout-Swift#4. It makes some changes to the haptics implementation in the about screen so that haptics are only active when the app logos cell on the new About screen is visible.

To test

Presenting new screens

• Build and run on a device
• Navigate to the new About screen (in the Me menu)
• Ensure you can see the app logos cell containing the bubbles, and that you can feel the haptic feedback
• Tap the Legal and More menu item, which pushes a new screen. Check that you can no longer feel the haptics. Tap Back, and ensure that the haptics come back.
• Tap the Blog menu item, which presents a webview. Check that you can no longer feel the haptics. Tap Back, and ensure that the haptics come back.

Scrolling on and offscreen

• In Xcode, go to AppAboutScreenConfiguration.swift and add the following line about 10 times to the first sub-array in the sections property (line 31) to pad out the top section in the screen with a lot of extra content:

AboutItem(title: "Testing"),

(this should go above the existing AboutItem(title: TextContent.rateUs, action: { [weak self] context in line)

• Relaunch the app and navigate to the About screen again. The app logos cell should be offscreen and you shouldn't feel any haptics.
• Scroll down so that the logo cell is visible. You should start feeling haptics.
• Scroll back up so that the logo cell is no longer visible. You shouldn't feel the haptics any more.

Regression Notes

1. Potential unintended areas of impact

None

2. What I did to test those areas of impact (or what existing automated tests I relied on)
3. What automated tests I added (or what prevented me from doing so)

N/A

PR submission checklist:

• I have completed the Regression Notes.
• I have considered adding unit tests for my changes.
• I have considered adding accessibility improvements for my changes.
• I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

[peril-wordpress-mobile]

You can trigger an installable build for these changes by visiting CircleCI here.

[peril-wordpress-mobile]

You can trigger optional UI/connected tests for these changes by visiting CircleCI here.

[Gio2018]

Hey @frosty , tested this on iPhone 12 Pro Max device with iOS 15.2; I noticed that the haptics do not pause when opening a modal with any web view from the about screen (Blog, Automattic Family and Work With Us). They correctly pause when offscreen or when navigating to legal and more.

[frosty]

Hmm you're right, it's not working in the case of modals like the webviews, because they don't trigger the willAppear / disappear view lifecycle methods. As I'm currently wrapping up for the holidays, I'd like to go ahead and merge this as-is for now (as it's still an improvement over what we had already) and I can see if there's anything we can do about the modals in a future update. Is that okay?

[Gio2018]

Hey @frosty , sure let's merge this one. Since it's not a blocker, we can open an issue for the haptic still happening when the modal web view shows up and treat it in a separate PR. Happy Holidays!!