Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editor: Reset search query when media picker is dismissed #18980

Merged
merged 2 commits into from Jul 6, 2022

Conversation

hassaanelgarem
Copy link
Contributor

@hassaanelgarem hassaanelgarem commented Jul 4, 2022

Part of #18840

Description

Fixes an issue in the editor where the search query was being retained even after dismissing the media picker.

Testing Instructions

  1. Create a new blog post
  2. Add an Image block
  3. Click ADD IMAGE
  4. Click WordPress Media Library
  5. Search for some string that will not return any results
  6. Click Cancel button in Navigation bar
  7. Click ADD IMAGE
  8. Click WordPress Media Library
  9. Make sure that all the available images are displayed.

Regression Notes

  1. Potential unintended areas of impact
    N/A
  2. What I did to test those areas of impact (or what existing automated tests I relied on)
    N/A
  3. What automated tests I added (or what prevented me from doing so)
    N/A

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding unit tests for my changes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@hassaanelgarem hassaanelgarem added [Type] Bug Media Gutenberg Editing and display of Gutenberg blocks. labels Jul 4, 2022
@hassaanelgarem hassaanelgarem added this to the 20.3 milestone Jul 4, 2022
@hassaanelgarem hassaanelgarem self-assigned this Jul 4, 2022
@wpmobilebot
Copy link
Contributor

wpmobilebot commented Jul 4, 2022

You can test the changes in Jetpack from this Pull Request by:
  • Clicking here or scanning the QR code below to access App Center
  • Then installing the build number pr18980-9c33bfe on your iPhone

If you need access to App Center, please ask a maintainer to add you.

@wpmobilebot
Copy link
Contributor

wpmobilebot commented Jul 4, 2022

You can test the changes in WordPress from this Pull Request by:
  • Clicking here or scanning the QR code below to access App Center
  • Then installing the build number pr18980-9c33bfe on your iPhone

If you need access to App Center, please ask a maintainer to add you.

Copy link
Contributor

@momo-ozawa momo-ozawa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as described!

@hassaanelgarem hassaanelgarem merged commit 3a0813a into trunk Jul 6, 2022
@hassaanelgarem hassaanelgarem deleted the issue/18840-reset-media-search-query branch July 6, 2022 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Gutenberg Editing and display of Gutenberg blocks. Media [Type] Bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants