-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Jetpack Focus: Display phase two/three overlays for Stats, Reader, and Notifications #19703
Conversation
Without injecting the date
You can test the changes in WordPress from this Pull Request by:
|
You can test the changes in Jetpack from this Pull Request by:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works as described
Was looking on the files added in this PR and noticed there weren't any tests added, do we have any Unit Tests for the Remote config? |
Testing I did for this PR. Wanted to test the Day Frequency logic by adjusting the tie but looks like the only way to change the time configuration was in the
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Closes #19593
Description
This PR displays the feature-specific overlay for phases two and three for Stats, Reader, and Notification.
Notes
To facilitate testing, these changes have been pushed and will be reverted before merging, hence the "Do not merge" label.
Screenshots
Testing Instructions
Phase Two
Phase Three
Regression Notes
Potential unintended areas of impact
N/A
What I did to test those areas of impact (or what existing automated tests I relied on)
N/A
What automated tests I added (or what prevented me from doing so)
N/A
PR submission checklist:
RELEASE-NOTES.txt
if necessary.