Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] - Gutenberg - Drag and drop images #22058

Draft
wants to merge 3 commits into
base: trunk
Choose a base branch
from

Conversation

geriux
Copy link
Member

@geriux geriux commented Nov 17, 2023

Related to wordpress-mobile/gutenberg-mobile#6384

To test:

Regression Notes

  1. Potential unintended areas of impact

  2. What I did to test those areas of impact (or what existing automated tests I relied on)

  3. What automated tests I added (or what prevented me from doing so)

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding unit tests for my changes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

UI Changes testing checklist:

  • Portrait and landscape orientations.
  • Light and dark modes.
  • Fonts: Larger, smaller and bold text.
  • High contrast.
  • VoiceOver.
  • Languages with large words or with letters/accents not frequently used in English.
  • Right-to-left languages. (Even if translation isn’t complete, formatting should still respect the right-to-left layout)
  • iPhone and iPad.
  • Multi-tasking: Split view and Slide over. (iPad)

@geriux geriux added [Status] DO NOT MERGE Gutenberg Editing and display of Gutenberg blocks. labels Nov 17, 2023
@wpmobilebot
Copy link
Contributor

WordPress Alpha📲 You can test the changes from this Pull Request in WordPress Alpha by scanning the QR code below to install the corresponding build.
App NameWordPress Alpha WordPress Alpha
ConfigurationRelease-Alpha
Build Numberpr22058-2fd15a4
Version23.7
Bundle IDorg.wordpress.alpha
Commit2fd15a4
App Center BuildWPiOS - One-Offs #7873
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@wpmobilebot
Copy link
Contributor

Jetpack Alpha📲 You can test the changes from this Pull Request in Jetpack Alpha by scanning the QR code below to install the corresponding build.
App NameJetpack Alpha Jetpack Alpha
ConfigurationRelease-Alpha
Build Numberpr22058-2fd15a4
Version23.7
Bundle IDcom.jetpack.alpha
Commit2fd15a4
App Center Buildjetpack-installable-builds #6897
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

This is necessary to get up to date with a CI configuration change that
requires running on Xcode 15.1.

See #22270

---

There were conflicts because the Gutenberg version move forward on
`trunk` and this branch. I resolved by keeping Gutenberg to the version
here because that's the point of this branch, but given the time delta
it's possible the build will fail.
@mokagio
Copy link
Contributor

mokagio commented Jan 8, 2024

@geriux FYI: I merged trunk to make CI run on Apple Silicon. There were conflicts because the Gutenberg version move forward on trunk and this branch. I resolved by keeping Gutenberg to the version here because that's the point of this branch, but given the time delta it's possible the build will fail.

@wordpress-mobile wordpress-mobile deleted a comment from wpmobilebot Jan 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Gutenberg Editing and display of Gutenberg blocks. [Status] DO NOT MERGE
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants