Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Gutenberg] Test Fix crash when appending media #22177

Closed
wants to merge 1 commit into from

Conversation

geriux
Copy link
Member

@geriux geriux commented Dec 7, 2023

Do not merge, this PR is to generate a build with the Gutenberg changes.

Regression Notes

  1. Potential unintended areas of impact

  2. What I did to test those areas of impact (or what existing automated tests I relied on)

  3. What automated tests I added (or what prevented me from doing so)

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding unit tests for my changes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

UI Changes testing checklist:

  • Portrait and landscape orientations.
  • Light and dark modes.
  • Fonts: Larger, smaller and bold text.
  • High contrast.
  • VoiceOver.
  • Languages with large words or with letters/accents not frequently used in English.
  • Right-to-left languages. (Even if translation isn’t complete, formatting should still respect the right-to-left layout)
  • iPhone and iPad.
  • Multi-tasking: Split view and Slide over. (iPad)

@geriux geriux added [Status] DO NOT MERGE Gutenberg Editing and display of Gutenberg blocks. labels Dec 7, 2023
@geriux geriux added this to the 24.0 milestone Dec 7, 2023
@wpmobilebot
Copy link
Contributor

1 Error
🚫 This PR is tagged with [Status] DO NOT MERGE label(s).

Generated by 🚫 Danger

@wpmobilebot
Copy link
Contributor

WordPress Alpha📲 You can test the changes from this Pull Request in WordPress Alpha by scanning the QR code below to install the corresponding build.
App NameWordPress Alpha WordPress Alpha
ConfigurationRelease-Alpha
Build Numberpr22177-d69d7c3
Version23.8
Bundle IDorg.wordpress.alpha
Commitd69d7c3
App Center BuildWPiOS - One-Offs #8076
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@wpmobilebot
Copy link
Contributor

Jetpack Alpha📲 You can test the changes from this Pull Request in Jetpack Alpha by scanning the QR code below to install the corresponding build.
App NameJetpack Alpha Jetpack Alpha
ConfigurationRelease-Alpha
Build Numberpr22177-d69d7c3
Version23.8
Bundle IDcom.jetpack.alpha
Commitd69d7c3
App Center Buildjetpack-installable-builds #7096
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@geriux geriux closed this Dec 11, 2023
@geriux geriux deleted the gutenberg/test-fix-append-unsupported-media branch December 11, 2023 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Gutenberg Editing and display of Gutenberg blocks. [Status] DO NOT MERGE
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants