-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test branch for release automation in CI #22194
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This test build failed in a way that made me think might be due to not enough time having passed between the branch push to GitHub and the request to set protection, https://buildkite.com/automattic/wordpress-ios/builds/18989
ab083f0
to
c8997b3
Compare
|
App Name | ![]() |
|
Configuration | Release-Alpha | |
Build Number | pr22194-9e4281d | |
Version | 23.8 | |
Bundle ID | org.wordpress.alpha | |
Commit | 9e4281d | |
App Center Build | WPiOS - One-Offs #8106 |
|
App Name | ![]() |
|
Configuration | Release-Alpha | |
Build Number | pr22194-9e4281d | |
Version | 23.8 | |
Bundle ID | com.jetpack.alpha | |
Commit | 9e4281d | |
App Center Build | jetpack-installable-builds #7126 |
756e8ed
to
394e5b8
Compare
394e5b8
to
a4e2dd3
Compare
6f3bd05
to
62bb18a
Compare
Generated by 🚫 Danger |
This was referenced Dec 12, 2023
29a7d19
to
e8deffc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to test #22192.
Update: The PR was created before the changes from #22214 , as such, it's now out of sync with #22192. Still, the overall logic is the same, as the #22214 changes were mostly tweaks. The only main difference, trivial I hope, is that these tests run without the logic that creates the integration branch for the beta e8deffc
Step 1
trigger_code_freeze_in_ci
Build example: https://buildkite.com/automattic/wordpress-ios/builds/18998
Step 2
trigger_complete_code_freeze_in_ci
When no release version given:
With
release_version:23.9
Build: https://buildkite.com/automattic/wordpress-ios/builds/19019
Integration PR: #22195
Step 3 release notes editorialization
Use the lane to create the editorialization branch,
bundle exec fastlane create_editorial_branch branch:release/23.9-test
(thebranch
parameter is only needed in this test because of the test flow where the code freeze hasn't been merged intotrunk
). After adding the editorialized release notes, push, and trigger the CI build withtrigger_update_app_store_strings
Build: https://buildkite.com/automattic/wordpress-ios/builds/19023#_
Integration PR: #22196
Step 4
trigger_new_beta_release_in_ci
Build: https://buildkite.com/automattic/wordpress-ios/builds/19052
Integration PR: N.A. – Unfortunately the localization linting fails, which prevents deploying and creating a PR
On the other hand, it's a good demo of how the build would fail once rolled out. It makes me think that we might want to surface those failures as build annotations.
Note: this build failed because the 23.9 code freeze hadn't been merged on
trunk
yet so the computed versionrelease_version_current
turned out to be 23.8, for which a release branch no longer exists. With the move to the bot opening the integration PRs for us, this should become an even rarer occurrence, given the release manager will be able to merge the integration PR themselves.Step 5
trigger_finalize_release_in_ci
Build: https://buildkite.com/automattic/wordpress-ios/builds/19054
Integration PR: #22209