Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test Fixes to Run Xcode 15 in CI #22270

Merged
merged 16 commits into from
Jan 8, 2024
Merged

Test Fixes to Run Xcode 15 in CI #22270

merged 16 commits into from
Jan 8, 2024

Commits on Dec 19, 2023

  1. add working changes from mokagio/fix-code-15-tests branch

    @jostnes
    jostnes committed Dec 19, 2023
    Configuration menu
    Copy the full SHA
    49aedbb View commit details
    Browse the repository at this point in the history

Commits on Dec 20, 2023

  1. increase timeouts on verifyStatsLoaded and verifyChartLoaded

    @jostnes
    jostnes committed Dec 20, 2023
    Configuration menu
    Copy the full SHA
    8be833b View commit details
    Browse the repository at this point in the history

Commits on Dec 22, 2023

  1. Merge branch 'trunk' into ui-test-fixes-ios17.2

    @jostnes
    jostnes committed Dec 22, 2023
    Configuration menu
    Copy the full SHA
    11aa3d4 View commit details
    Browse the repository at this point in the history

Commits on Dec 26, 2023

  1. Merge branch 'trunk' into ui-test-fixes-ios17.2

    @jostnes
    jostnes committed Dec 26, 2023
    Configuration menu
    Copy the full SHA
    6ba9000 View commit details
    Browse the repository at this point in the history

Commits on Jan 3, 2024

  1. Reimplement waitForElementAndTap... as a typed XCUIElement method 

    "Typed" in that it expects an `enum` instead of a `String` to define the
expected element state.
    @mokagio
    mokagio committed Jan 3, 2024
    Configuration menu
    Copy the full SHA
    b442842 View commit details
    Browse the repository at this point in the history

  2. Remove unused waitForElementAndTap method. 

    It became unused in the previous commit,
b442842
    @mokagio
    mokagio committed Jan 3, 2024
    Configuration menu
    Copy the full SHA
    05597db View commit details
    Browse the repository at this point in the history

  3. Add a check for the "Not Now" button existence

    @mokagio
    mokagio committed Jan 3, 2024
    Configuration menu
    Copy the full SHA
    7f86de8 View commit details
    Browse the repository at this point in the history

  4. Allow a date-bound unit test to fail 

    To follow up via
#22323
    @mokagio
    mokagio committed Jan 3, 2024
    Configuration menu
    Copy the full SHA
    7365c10 View commit details
    Browse the repository at this point in the history

  5. Fix logic to evaluate .dismissed condition 

    🤦‍♂️ I didn't notice the `!` at the start of the check when porting
it over.
    @mokagio
    mokagio committed Jan 3, 2024
    Configuration menu
    Copy the full SHA
    de82f79 View commit details
    Browse the repository at this point in the history

  6. Use consistent indentation in XCUIElement+TapUntil

    @mokagio
    mokagio committed Jan 3, 2024
    Configuration menu
    Copy the full SHA
    d2cba4d View commit details
    Browse the repository at this point in the history

Commits on Jan 4, 2024

  1. Merge branch 'trunk' into ui-test-fixes-ios17.2

    @jostnes
    jostnes committed Jan 4, 2024
    Configuration menu
    Copy the full SHA
    a1ebec0 View commit details
    Browse the repository at this point in the history

  2. Reimplement waitForElementAndTap... as a typed XCUIElement method (… 

    …#22322)
    @jostnes
    jostnes committed Jan 4, 2024
    Configuration menu
    Copy the full SHA
    cdc34d1 View commit details
    Browse the repository at this point in the history

Commits on Jan 8, 2024

  1. Work around unit test failing because of 2023 vs 2024 issue

    @mokagio
    mokagio committed Jan 8, 2024
    Configuration menu
    Copy the full SHA
    39cb20f View commit details
    Browse the repository at this point in the history

  2. Address RuboCop violation

    @mokagio
    mokagio committed Jan 8, 2024
    Configuration menu
    Copy the full SHA
    a6b9305 View commit details
    Browse the repository at this point in the history

  3. Revert "Work around unit test failing because of 2023 vs 2024 issue" 

    This reverts commit 39cb20f.
    @mokagio
    mokagio committed Jan 8, 2024
    Configuration menu
    Copy the full SHA
    faa1d72 View commit details
    Browse the repository at this point in the history

  4. Tests: Fix failure in BloggingPromptsServiceTests

    @hassaanelgarem @mokagio
    hassaanelgarem authored and mokagio committed Jan 8, 2024
    Configuration menu
    Copy the full SHA
    5bafb56 View commit details
    Browse the repository at this point in the history