Stats Traffic: Increase number of weeks to fetch for monthly chart

[staskus]

More context: p1709642938683799/1709576037.356079-slack-C06BR07TJHK

Long months, such as October 2023 have 6 weeks that fall into one month's range. We should fetch 6 weeks to make sure they are included in the charts. View Model makes sure that the weeks that don't belong to a given month are not shown in a chart.

To test:

1. Enable Stats Traffic feature flag
2. Open Stats, Traffic
3. Select Month
4. Go through months and confirm that we show all (no more and less) weeks that fall into a provided month's range.

Regression Notes

1. Potential unintended areas of impact

Couldn't identify any

2. What I did to test those areas of impact (or what existing automated tests I relied on)

3. What automated tests I added (or what prevented me from doing so)

PR submission checklist:

• I have completed the Regression Notes.
• I have considered adding unit tests for my changes.
• I have considered adding accessibility improvements for my changes.
• I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

Testing checklist:

• WordPress.com sites and self-hosted Jetpack sites.
• Portrait and landscape orientations.
• Light and dark modes.
• Fonts: Larger, smaller and bold text.
• High contrast.
• VoiceOver.
• Languages with large words or with letters/accents not frequently used in English.
• Right-to-left languages. (Even if translation isn’t complete, formatting should still respect the right-to-left layout)
• iPhone and iPad.
• Multi-tasking: Split view and Slide over. (iPad)

[wpmobilebot]

📲 You can test the changes from this Pull Request in WordPress Alpha by scanning the QR code below to install the corresponding build.

	App Name	WordPress Alpha
	Configuration	Release-Alpha
	Build Number	pr22826-1210657
	Version	24.4
	Bundle ID	org.wordpress.alpha
	Commit	1210657
	App Center Build	WPiOS - One-Offs #9145

Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

[wpmobilebot]

📲 You can test the changes from this Pull Request in Jetpack Alpha by scanning the QR code below to install the corresponding build.

	App Name	Jetpack Alpha
	Configuration	Release-Alpha
	Build Number	pr22826-1210657
	Version	24.4
	Bundle ID	com.jetpack.alpha
	Commit	1210657
	App Center Build	jetpack-installable-builds #8189

Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

[guarani]

Sorry for the delay reviewing this, @staskus.

I ran into some bugs which I'll detail below.

An error occurred when viewing certain weeks

I thought it might be related to Oct having six calendar weeks, but it looks to be related to DST kicking in in my timezone on Oct 1st.

On the team P2 with the week of "Sep 25 - Oct 1, 2023" selected, the screen doesn't load and `An error occurred" is shown:

See screenshot

self.periodDataQueryDateFormatter.date(from: "2023-10-01") returns nil for me, which ends up being due to clocking moving forward one hour at that time. Adding df.timeZone = TimeZone(secondsFromGMT: 0) seems to fix the issue.

This is unrelated to this PR, so not a blocker.

Zero counts display for month of Oct 2023

Oct 2023 also shows zeros for Views/Visitors/Likes/Comments for me:

See screenshot

I didn't have time to finish looking into this unfortunately, but it's reproducible without this change, so again not a blocker. I think it's likely the same issue we say in March 2024 (the one you raised in p1709296218622579-slack-C82FZ5T4G).

---

I think this PR is fine. I see the six bars in Oct 2023 now and the counts look correct. I think the above are existing, unrelated issues.

[staskus]

@guarani

self.periodDataQueryDateFormatter.date(from: "2023-10-01") returns nil for me, which ends up being due to clocking moving forward one hour at that time. Adding df.timeZone = TimeZone(secondsFromGMT: 0) seems to fix the issue.

Certainly this is a bug that needs to be fixed. I wonder if it also happens to users that see these "An error occurred errors"

I didn't have time to finish looking into this unfortunately, but it's reproducible without this change, so again not a blocker. I think it's likely the same issue we say in March 2024 (the one you raised in p1709296218622579-slack-C82FZ5T4G).

This workaround should've resolved issues such as these. #22750 Although that workaround by itself needs to be improved #22750 (comment) which I haven't done.

[staskus]

Added 2 issues to the project:

• Stats: Limit date to current site date when fetching Stats totals from stats/visits endpoint #22858
• Stats Traffic: Card information fails to load when date cannot be parsed when returned from API #22859

[guarani]

Certainly this is a bug that needs to be fixed. I wonder if it also happens to users that see these "An error occurred errors"

I don't think this is related to the "An error occurred" errors I saw in #12945 (comment), which was for this month (not Oct 2023).

This workaround should've resolved issues such as these. #22750 Although that workaround by itself needs to be improved #22750 (comment) which I haven't done.

I think it might be best to start looking into the backend. I didn't follow up on this over the last few weeks because it seemed low-priority, but it's happened in Oct 2023 and Feb 2024 IIRC.