Reading Preferences: Fix sizing issues for post detail and web-based comments #22939
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #22925
Depends on #22938
This PR fixes the sizing issue for the header view, post webview, and comment webview in Reader Detail. This should also resolve sizing issues raised in #22851 (review) and potentially #21797.
GeometryReader
to report for content size changes.ReaderDisplaySetting
makes use of the web view's zoom level to increase the content scale, we'd also need to manually calculate the scale after getting the web view's height since it looks like thescrollHeight
property does not take zoom level into account.To test
Reader Customization
flag is turned on.Sans
for font andNormal
for size (right in the middle).Regression Notes
Potential unintended areas of impact
Should be none. While the web view calculations take
ReaderDisplaySetting
's scale into account, when the flag is off, the display setting is set to.standard
, which has a scale value of1.0
.What I did to test those areas of impact (or what existing automated tests I relied on)
Manually tested the changes.
What automated tests I added (or what prevented me from doing so)
N/A.
PR submission checklist:
RELEASE-NOTES.txt
if necessary.Testing checklist: