Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reading Preferences: Fix customization sheet #22967

Merged
merged 13 commits into from
Apr 9, 2024

Conversation

dvdchr
Copy link
Contributor

@dvdchr dvdchr commented Apr 4, 2024

Part of #22925

In this PR, several improvements are included for the customization sheet, which should also address the issues raised in #22851 (review):

  • The navigation bar button now adapts to the currently highlighted color theme.
  • Added decent/passable support for landscape mode.
  • Added accessibility support.
  • Added h4x0r and Candy themes. 馃帹
  • Added a soft gradient at the bottom of the Preview section to indicate that there are more contents to scroll.
  • Added the actual feedback survey link.
Portrait Landscape
Simulator Screenshot - iPhone 15 - 2024-04-05 at 03 08 45 Simulator Screenshot - iPhone 15 - 2024-04-05 at 03 28 38

To test

  • Launch the Jetpack app.
  • Ensure that the Reader Customization flag is enabled.
  • Go to the Reader tab and open any post.
  • Tap the reading preferences button.
  • 馃攷 Test the screen with various configurations. Verify that the contents are all reachable, both in portrait and landscape mode.
  • 馃攷 Test with VoiceOver, and verify that the hierarchy of the customization sheet makes sense.

Regression Notes

  1. Potential unintended areas of impact
    Should be none. This change is isolated to the customization sheet, which is a new component that's hidden behind a disabled feature flag.

  2. What I did to test those areas of impact (or what existing automated tests I relied on)
    Manually tested the changes.

  3. What automated tests I added (or what prevented me from doing so)
    N/A.

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding unit tests for my changes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

Testing checklist:

  • WordPress.com sites and self-hosted Jetpack sites.
  • Portrait and landscape orientations.
  • Light and dark modes.
  • Fonts: Larger, smaller and bold text.
  • High contrast.
  • VoiceOver.
  • Languages with large words or with letters/accents not frequently used in English.
  • Right-to-left languages. (Even if translation isn鈥檛 complete, formatting should still respect the right-to-left layout)
  • iPhone and iPad.
  • Multi-tasking: Split view and Slide over. (iPad)

@dvdchr dvdchr added [Type] Enhancement Reader Part of a WIP Feature This label is used to disable milestone checks for PRs that are not against `develop` or `release`. labels Apr 4, 2024
@dvdchr dvdchr added this to the 24.7 milestone Apr 4, 2024
@dvdchr dvdchr self-assigned this Apr 4, 2024
@dvdchr dvdchr mentioned this pull request Apr 4, 2024
11 tasks
@wpmobilebot
Copy link
Contributor

wpmobilebot commented Apr 4, 2024

WordPress Alpha馃摬 You can test the changes from this Pull Request in WordPress Alpha by scanning the QR code below to install the corresponding build.
App NameWordPress Alpha WordPress Alpha
ConfigurationRelease-Alpha
Build Numberpr22967-31d3599
Version24.6
Bundle IDorg.wordpress.alpha
Commit31d3599
App Center BuildWPiOS - One-Offs #9399
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@wpmobilebot
Copy link
Contributor

wpmobilebot commented Apr 4, 2024

Jetpack Alpha馃摬 You can test the changes from this Pull Request in Jetpack Alpha by scanning the QR code below to install the corresponding build.
App NameJetpack Alpha Jetpack Alpha
ConfigurationRelease-Alpha
Build Numberpr22967-31d3599
Version24.6
Bundle IDcom.jetpack.alpha
Commit31d3599
App Center Buildjetpack-installable-builds #8443
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

Copy link
Contributor

@wargcm wargcm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 馃殌

@dvdchr dvdchr merged commit 2848f45 into trunk Apr 9, 2024
24 checks passed
@dvdchr dvdchr deleted the issue/22925-fix-customization-sheet branch April 9, 2024 06:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Part of a WIP Feature This label is used to disable milestone checks for PRs that are not against `develop` or `release`. Reader [Type] Enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants