-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Notifications Refresh] Replace tabs with dropdown in notifications screen #23054
[Notifications Refresh] Replace tabs with dropdown in notifications screen #23054
Conversation
|
App Name | ![]() |
|
Configuration | Release-Alpha | |
Build Number | pr23054-96ddcb7 | |
Version | 24.7 | |
Bundle ID | org.wordpress.alpha | |
Commit | 96ddcb7 | |
App Center Build | WPiOS - One-Offs #9653 |
|
App Name | ![]() |
|
Configuration | Release-Alpha | |
Build Number | pr23054-96ddcb7 | |
Version | 24.7 | |
Bundle ID | com.jetpack.alpha | |
Commit | 96ddcb7 | |
App Center Build | jetpack-installable-builds #8697 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks amazing! It's a pure pleasure to use this and the Notifications tab looks really fresh in its final appearance! 👏
I also updated the GH issue to include the update about removing icons from the menu items.
@@ -19,6 +19,11 @@ extension NotificationsViewController { | |||
value: "Navigation Bar Menu Button", | |||
comment: "Accessibility label for the navigation bar menu button" | |||
) | |||
static let allNotificationsTitle = NSLocalizedString( | |||
"notificationsViewController.navigationBar.filters.allNotifications", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does it make sense to use notificationsViewController
as key here? Wouldn't we be better of naming this without technical details, something like notifications.header.filters.all.notifications
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Resolved in 96ddcb7. I didn't replace "navigationBar" with "headers" though, as I think "navigationBar" is not too much technical.
bed9bfd
to
96ddcb7
Compare
7b25e64
into
feature/notifications_refresh_p2
Fixes https://github.com/Automattic/wordpress-mobile/issues/9
Test Instructions
Regression Notes
Potential unintended areas of impact
Make sure the correct filter is applied when selecting dropdown options.
What I did to test those areas of impact (or what existing automated tests I relied on)
Manual testing.
What automated tests I added (or what prevented me from doing so)
None.
PR submission checklist:
RELEASE-NOTES.txt
if necessary.Testing checklist: