Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Notifications Refresh] Replace tabs with dropdown in notifications screen #23054

Conversation

salimbraksa
Copy link
Contributor

@salimbraksa salimbraksa commented Apr 22, 2024

Fixes https://github.com/Automattic/wordpress-mobile/issues/9

Light Dark
CleanShot 2024-04-24 at 10 15 48@2x CleanShot 2024-04-24 at 10 16 02@2x

Test Instructions

  1. Run the app and login.
  2. Navigate to the Notifications screen
  3. Click on the title in the navigation bar
  4. It should display a dropdown menu
  5. Click on the menu options
  6. The dropdown should be dismissed, and then switch to the filter category you clicked, the title should be updated.

Regression Notes

  1. Potential unintended areas of impact
    Make sure the correct filter is applied when selecting dropdown options.

  2. What I did to test those areas of impact (or what existing automated tests I relied on)
    Manual testing.

  3. What automated tests I added (or what prevented me from doing so)
    None.

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding unit tests for my changes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

Testing checklist:

  • WordPress.com sites and self-hosted Jetpack sites.
  • Portrait and landscape orientations.
  • Light and dark modes.
  • Fonts: Larger, smaller and bold text.
  • High contrast.
  • VoiceOver.
  • Languages with large words or with letters/accents not frequently used in English.
  • Right-to-left languages. (Even if translation isn’t complete, formatting should still respect the right-to-left layout)
  • iPhone and iPad.
  • Multi-tasking: Split view and Slide over. (iPad)

@wpmobilebot
Copy link
Contributor

wpmobilebot commented Apr 22, 2024

WordPress Alpha📲 You can test the changes from this Pull Request in WordPress Alpha by scanning the QR code below to install the corresponding build.
App NameWordPress Alpha WordPress Alpha
ConfigurationRelease-Alpha
Build Numberpr23054-96ddcb7
Version24.7
Bundle IDorg.wordpress.alpha
Commit96ddcb7
App Center BuildWPiOS - One-Offs #9653
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@wpmobilebot
Copy link
Contributor

wpmobilebot commented Apr 22, 2024

Jetpack Alpha📲 You can test the changes from this Pull Request in Jetpack Alpha by scanning the QR code below to install the corresponding build.
App NameJetpack Alpha Jetpack Alpha
ConfigurationRelease-Alpha
Build Numberpr23054-96ddcb7
Version24.7
Bundle IDcom.jetpack.alpha
Commit96ddcb7
App Center Buildjetpack-installable-builds #8697
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@salimbraksa salimbraksa marked this pull request as ready for review April 24, 2024 06:55
@salimbraksa salimbraksa changed the base branch from trunk to feature/notifications_refresh_p2 April 24, 2024 11:39
Copy link
Contributor

@justtwago justtwago left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks amazing! It's a pure pleasure to use this and the Notifications tab looks really fresh in its final appearance! 👏

I also updated the GH issue to include the update about removing icons from the menu items.

@@ -19,6 +19,11 @@ extension NotificationsViewController {
value: "Navigation Bar Menu Button",
comment: "Accessibility label for the navigation bar menu button"
)
static let allNotificationsTitle = NSLocalizedString(
"notificationsViewController.navigationBar.filters.allNotifications",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does it make sense to use notificationsViewController as key here? Wouldn't we be better of naming this without technical details, something like notifications.header.filters.all.notifications?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Resolved in 96ddcb7. I didn't replace "navigationBar" with "headers" though, as I think "navigationBar" is not too much technical.

@salimbraksa salimbraksa force-pushed the task/notifications-replace-tabs-with-dropdown branch from bed9bfd to 96ddcb7 Compare April 25, 2024 07:24
@salimbraksa salimbraksa merged commit 7b25e64 into feature/notifications_refresh_p2 Apr 25, 2024
24 checks passed
@salimbraksa salimbraksa deleted the task/notifications-replace-tabs-with-dropdown branch April 25, 2024 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants